<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104621/">http://git.reviewboard.kde.org/r/104621/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 17th, 2012, 1:45 p.m., <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change is wrong, as the menu entry has nothing to do with the semantic meaning of the icon, and the icon is not named according to the icon spec.
So the correct icon is already set here, if its look doesn't match, then that icon would need to be fixed. In this case, I assume you mean to better reflect the "online" part in the name, and I agree that it's not reflected in the name. Question is: does it matter where the help is located? (Surely does if the user is offline, but in general ... I think the "help!" part is important, not the "online" part.</pre>
</blockquote>
<p>On April 17th, 2012, 4:31 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+1</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The openSuse icons had me confused. The one I mean is 'applications-internet'
The current icon is the same as most other entries: a book with a question mark. Not really wrong, but not correct/obvious either.
I do however think that the 'online' part is more important. If you are in the help center EVERYTHING is 'help', it should be more obvious what the difference is between the available options to get help. And these days more and more help is located online and no longer limited to only documentation. (think forums, wiki, ...) I wish for the help center to be more of place to go when you have problems than a handy manual reader. (In all honesty changing a little icon won't make much difference)
As this is my first patch I'm not sure what the policy is to do now. Close as discarded or leave open?</pre>
<br />
<p>- Maarten</p>
<br />
<p>On April 16th, 2012, 5:28 p.m., Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Cornelius Schumacher.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated April 16, 2012, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes the 'Online help' icon in the navigation to a more fitting one.(imho)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiled and run, works fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khelpcenter/plugins/onlinehelp.desktop <span style="color: grey">(540f83f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104621/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>