<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104617/">http://git.reviewboard.kde.org/r/104617/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 12645a4a933a5b06016df2f35d90a055fd0c8dab by Dawit Alemayehu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 16th, 2012, 2:06 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Andreas Schneider.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 16, 2012, 2:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch does the following:
- Removed code that set the port number to the one specified in /etc/services since it is completely the wrong thing to do for a client application.
- Cleaned up header includes.
Using the port number from /etc/services as a default is a common mistake that was fixed in all the other protocols a long while back. kio_sftp should not do that because if the port number is changed in /etc/services to something else other than port# 22, then it would be impossible for the user to login into another ssh server without explicitly specifying the port number as part of the url.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/sftp/kio_sftp.h <span style="color: grey">(ca2b4ac)</span></li>
<li>kioslave/sftp/kio_sftp.cpp <span style="color: grey">(f8591f8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104617/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>