<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104614/">http://git.reviewboard.kde.org/r/104614/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch, I've not been aware that this caching-issue can be solved like this :-) I guess this patch has not been applied to the latest master: DolphinView does not have a dir-lister anymore (it has been moved to KFileItemModel). Anyhow: Please just let me rebase the patch myself so that I can catch all cases - I'll push the patch to master during the next days.</pre>
<br />
<p>- Peter</p>
<br />
<p>On April 16th, 2012, 1:26 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and Peter Penz.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 16, 2012, 1:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch sets the main window on the main directory lister in DolphinView and KIO jobs in DolphinMainWindow to ensure that login data for remote protocols such as sftp, ftp are cached properly for the duration of the application. Otherwise, the end user is going to end up being unnecessarily re-prompted to enter password login information.
Please note that this patch does not address every use of KIO or KDirLister in Dolphin. There are other places in Dolphin's code where directory listers and/or jobs are used without setting the main window.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: grey">(947db77)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(78fd56d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104614/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>