<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104593/">http://git.reviewboard.kde.org/r/104593/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 13th, 2012, 9:51 p.m., <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The commit that has caused the compilation problem has already been addressed:
http://commits.kde.org/kdelibs/cd71839b04d7c754b9ec18f7b56522958b504006
http://commits.kde.org/kdelibs/d82f313500f9e4fe3a7e5ddef43650c31b59c8e3
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks for the info - no idea why I did not find that one yesterday...</pre>
<br />
<p>- Martin</p>
<br />
<p>On April 13th, 2012, 8:07 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 13, 2012, 8:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=86dcd810bc7bb1effb7a2831d0e7d49cab6e120d kdelibs KDE/4.8 requires Qt 4.8. Without it we get the following build error:
kdecore/network/ktcpsocket.cpp:47:10: error: ‘TlsV1SslV3’ is not a member of ‘QSsl’
kdecore/network/ktcpsocket.cpp:49:10: error: ‘SecureProtocols’ is not a member of ‘QSsl’
Given thread http://lists.kde.org/?l=kde-core-devel&m=133405344728456&w=2 I think it is best to require Qt 4.8 in CMake to get proper warnings at cmake check and not get a useless build error.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(040a24f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104593/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>