<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104529/">http://git.reviewboard.kde.org/r/104529/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1ae45acccc9180f92954886b1bc6e911fbc8c66f by Dawit Alemayehu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 10th, 2012, 4:52 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Andreas Schneider.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 10, 2012, 4:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following patch address a scenario the following sftp login related patches:
https://git.reviewboard.kde.org/r/101332/
https://git.reviewboard.kde.org/r/102428/
missed. Namely, what happens if the user presses cancel not in the original password dialog, but rather in the subsequent retry dialog. This could happen if the user made a typo when entering login and password originally. With this patch all the scenarios work as advertised and kio_sftp behaves almost exactly the same as kio_ftp.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Repeat the testing outlined in https://git.reviewboard.kde.org/r/101332/, but with the following change:
In step #1, instead of pressing cancel in the password dialog, enter incorrect login/password. Wait for the the retry dialog to pop up, and then press cancel.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/sftp/kio_sftp.cpp <span style="color: grey">(cfd9bcf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104529/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>