<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104149/">http://git.reviewboard.kde.org/r/104149/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 11c7c9adcce7f476b32128f104e2935c6e19ac9d by Daniele E. Domenichelli to branch KDE/4.8.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 4th, 2012, 2:58 a.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated March 4, 2012, 2:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KWidgetItemDelegate does not update when the itemView gets or loses the focus.
This may cause problems with the text colors of the selected indexes.
I'm not sure if this is the best way to do it, since in all the other places this is done asyncronously using "QTimer::singleShot(0, this, SLOT(initializeModel()))", but this initializes the whole model, and I think it is not needed here. The alternatives are to update the whole model, or to add another slot to initialize only selected items.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/itemviews/kwidgetitemdelegate.cpp <span style="color: grey">(828e498)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104149/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>