<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104200/">http://git.reviewboard.kde.org/r/104200/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great work! Soon the mysterious calmness in bugzilla will be over ;)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104200/diff/1/?file=52178#file52178line612" style="color: black; font-weight: bold; text-decoration: underline;">drkonqi/bugzillalib.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void BugzillaManager::searchBugsJobFinished(KJob * job)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">317</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">genericError</span> <span class="o">=</span> <span class="n">i18nc</span><span class="p">(</span><span class="s">"@info"</span><span class="p">,</span> <span class="s">"Received unexpected error code %1 from bugzilla. "</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">318</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">"Error message was: %2"</span><span class="p">,</span> <span class="n">errorCode</span><span class="p">,</span> <span class="n">errorString</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are string changes, so the permission from translation team would be needed before this is applied to any branch.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When there are no objections, I suggest to apply this to master to get more testing. Crash reporting does not work right now, so there is nothing that could break.
If possible, this should also be committed to 4.7 branch later, and distributions informed for an eventual online update.</pre>
<p>- Christoph</p>
<br />
<p>On March 9th, 2012, 12:45 a.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated March 9, 2012, 12:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch partially ports DrKonqi to use xml-rpc, which is done at this point to support the new bugzilla 4.2 instance on bugs.kde.org. I have tried to keep the changes as minimal as possible, so that this can be applied to the 4.8 branch.
Note that this patch involves copying the kxmlrpcclient library from kdepimlibs in drkonqi's source code tree. I have done this to avoid modifying dependencies in 4.8.2. However, if an extra dependency of kde-runtime on kdepimlibs sounds ok, I can remove the internal copy in master.
Full history at:
http://quickgit.kde.org/index.php?p=clones%2Fkde-runtime%2Fgkiagia%2Fdrkonqi.git&a=shortlog&h=refs/heads/drkonqi-xmlrpc</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sucessfully reported and attached extra backtrace on:
https://bugs4.kde.org/show_bug.cgi?id=294820
https://bugs4.kde.org/show_bug.cgi?id=294821
The duplicate search also seems to be working fine.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=295276">295276</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/CMakeLists.txt <span style="color: grey">(590239dfbd9236463ef11eede699eb84f5806b7a)</span></li>
<li>drkonqi/bugzillalib.h <span style="color: grey">(c89c85c8df3724dc6e51ed03aab7ef7362a22472)</span></li>
<li>drkonqi/bugzillalib.cpp <span style="color: grey">(2df29bd975196b13df02934bfa8899e30d9627f6)</span></li>
<li>drkonqi/drkonqi_globals.h <span style="color: grey">(9281b0574737632782c96f90dadad1c86abebd0c)</span></li>
<li>drkonqi/kxmlrpc/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/kxmlrpc/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/kxmlrpc/client.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/kxmlrpc/client.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/kxmlrpc/query.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/kxmlrpc/query.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/reportassistantpages_bugzilla.cpp <span style="color: grey">(fba91b6d179c867d9984d2296b7302a469c8d0e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104200/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>