<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104077/">http://git.reviewboard.kde.org/r/104077/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With Qt 4.8, there is usually no difference between QImage and QPixmap, so I do not think we should try to be smart here. There general rule is: Use QImage, if you need to access individual pixels, use QPixmap everywhere else. This way we can benefit from any optimizations that can only be applied to opaque datatypes (which QImage isn't).</pre>
<br />
<p>- Christoph</p>
<br />
<p>On February 25th, 2012, 5:42 p.m., Lukas Sommer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, KDE Runtime, kdelibs, Fredrik Höglund, and Christoph Feck.</div>
<div>By Lukas Sommer.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2012, 5:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With review request r101701 being submitted, there is still a remaining issue that wasn't solved: Scaling a QImage is expensive. So it is better to keep the data as QPixmap as long as necessary.
This patch implements a less expensive behaviour.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/input/xcursor/cursortheme.cpp <span style="color: grey">(2c8c260)</span></li>
<li>kcontrol/input/xcursor/themepage.cpp <span style="color: grey">(0f678ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104077/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>