<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103728/">http://git.reviewboard.kde.org/r/103728/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 13th, 2012, 9:31 p.m., <b>Oswald Buddenhagen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">with the metaobject work currently going on in qt5 (see kent hansen's gerrit dashboard), this normalization may well turn out to be even less worth the hassle than it already is (if normalization turns out to have a noteworthy impact on your code, you are probably Doing It Wrong).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The keyword there is "qt5". This was for the here and now. And I never said this change had a noteworthy impact on my or anyone else's code. In fact I said the performance win will be a minor one. But it is almost always a little thing here and a little thing there that add up to cause a big problem. At least in my years of working software that is what I experienced. This is especially true for large and long lived code bases like KDE's.
Anyhow, I would have completely agreed with your statement if this was something that had to be done manually. It was not. It was a matter of simply running a tool, normalize, that comes with Qt itself. As such it is safe to assume the less than 20 minutes I spent running the tool and reviewing the result is worth the effort. At least it was from my perspective.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On January 29th, 2012, 6:43 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2012, 6:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch simply normalizes all signal/slot connections in the kdelibs. It was done using Qt's normalize tool. This relatively simple and safe change provides a performance win however minor it may be. Any objections ?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dnssd/avahi-domainbrowser.cpp <span style="color: grey">(b60afc4)</span></li>
<li>dnssd/avahi-publicservice.cpp <span style="color: grey">(376ea018)</span></li>
<li>dnssd/avahi-remoteservice.cpp <span style="color: grey">(4f08870)</span></li>
<li>dnssd/avahi-servicebrowser.cpp <span style="color: grey">(a648446)</span></li>
<li>dnssd/avahi-servicetypebrowser.cpp <span style="color: grey">(ef16f8a)</span></li>
<li>dnssd/domainmodel.cpp <span style="color: grey">(234f3fa)</span></li>
<li>dnssd/mdnsd-servicebrowser.cpp <span style="color: grey">(c52daf5)</span></li>
<li>interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp <span style="color: grey">(15f590c)</span></li>
<li>interfaces/kmediaplayer/kfileaudiopreview/mediacontrols.cpp <span style="color: grey">(d5882cc)</span></li>
<li>kde3support/kdecore/k3procio.cpp <span style="color: grey">(3cdca07)</span></li>
<li>kde3support/kdeui/k3iconview.cpp <span style="color: grey">(3993c35)</span></li>
<li>kde3support/kdeui/k3iconviewsearchline.cpp <span style="color: grey">(e95c0e9)</span></li>
<li>kde3support/kdeui/k3listbox.cpp <span style="color: grey">(7c22d1f)</span></li>
<li>kde3support/kdeui/k3listview.cpp <span style="color: grey">(8fd170d)</span></li>
<li>kde3support/kdeui/k3listviewsearchline.cpp <span style="color: grey">(5404a8f)</span></li>
<li>kde3support/kdeui/k3passworddialog.cpp <span style="color: grey">(b9e40d8)</span></li>
<li>kde3support/kdeui/k3spell.cpp <span style="color: grey">(387abff)</span></li>
<li>kde3support/kdeui/k3spelldlg.cpp <span style="color: grey">(241040a)</span></li>
<li>kde3support/kdeui/k3syntaxhighlighter.cpp <span style="color: grey">(7f0a416)</span></li>
<li>kde3support/kdeui/k3textedit.cpp <span style="color: grey">(bf6d9c9)</span></li>
<li>kde3support/kio/kfile/k3filetreeview.cpp <span style="color: grey">(091058f)</span></li>
<li>kde3support/kio/kfile/k3fileview.cpp <span style="color: grey">(f3c395b)</span></li>
<li>kde3support/kio/kfile/kfiletreebranch.cpp <span style="color: grey">(abc4e32)</span></li>
<li>kde3support/kparts/dockmainwindow3.cpp <span style="color: grey">(b39d0ef)</span></li>
<li>kde3support/tests/itemcontainertest.cpp <span style="color: grey">(9d15180)</span></li>
<li>kde3support/tests/k3processtest.cpp <span style="color: grey">(919c7ea)</span></li>
<li>kde3support/tests/kcommandtest.cpp <span style="color: grey">(792b512)</span></li>
<li>kde3support/tests/kdockwidgetdemo.cpp <span style="color: grey">(eb9fa71)</span></li>
<li>kdecore/auth/backends/dbus/DBusHelperProxy.cpp <span style="color: grey">(3d13400)</span></li>
<li>kdecore/auth/kauthactionwatcher.cpp <span style="color: grey">(c4c44b7)</span></li>
<li>kdecore/io/kdirwatch.cpp <span style="color: grey">(e0a4056)</span></li>
<li>kdecore/jobs/kjobtrackerinterface.cpp <span style="color: grey">(a189b8f)</span></li>
<li>kdecore/network/k3clientsocketbase.cpp <span style="color: grey">(acbb824)</span></li>
<li>kdecore/network/k3datagramsocket.cpp <span style="color: grey">(c009ee2)</span></li>
<li>kdecore/network/k3resolver.cpp <span style="color: grey">(efc7428)</span></li>
<li>kdecore/network/k3serversocket.cpp <span style="color: grey">(04c7c98)</span></li>
<li>kdecore/network/ktcpsocket.cpp <span style="color: grey">(9bcfef3)</span></li>
<li>kdecore/sonnet/backgroundchecker.cpp <span style="color: grey">(5da0d51)</span></li>
<li>kdecore/sonnet/tests/test_dialog.cpp <span style="color: grey">(4689c36)</span></li>
<li>kdecore/tests/kdirwatchtest.cpp <span style="color: grey">(9c755bb)</span></li>
<li>kdecore/tests/kdirwatchtest_gui.cpp <span style="color: grey">(1bfb7e6)</span></li>
<li>kdecore/tests/kjobtest.cpp <span style="color: grey">(d3c0440)</span></li>
<li>kded/kded.cpp <span style="color: grey">(1497fa0)</span></li>
<li>kdeui/actions/kactionmenu.cpp <span style="color: grey">(f4a1391)</span></li>
<li>kdeui/actions/kfontaction.cpp <span style="color: grey">(111913d)</span></li>
<li>kdeui/actions/kselectaction.cpp <span style="color: grey">(1b70da6)</span></li>
<li>kdeui/actions/kstandardaction.cpp <span style="color: grey">(3475ad1)</span></li>
<li>kdeui/actions/ktoggleaction.cpp <span style="color: grey">(25123cd)</span></li>
<li>kdeui/actions/ktoolbarpopupaction.cpp <span style="color: grey">(0a2cd75)</span></li>
<li>kdeui/actions/ktoolbarspaceraction.cpp <span style="color: grey">(58f4ed0)</span></li>
<li>kdeui/colors/kcolordialog.cpp <span style="color: grey">(3e52c16)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp <span style="color: grey">(b9d2a9b)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp <span style="color: grey">(c15d928)</span></li>
<li>kdeui/dialogs/kassistantdialog.cpp <span style="color: grey">(8f9f702)</span></li>
<li>kdeui/dialogs/kbugreport.cpp <span style="color: grey">(582f3b0)</span></li>
<li>kdeui/dialogs/kconfigdialogmanager.cpp <span style="color: grey">(0890c0b)</span></li>
<li>kdeui/dialogs/kcupsoptionsjobwidget_p.cpp <span style="color: grey">(380ffa4)</span></li>
<li>kdeui/dialogs/kdialog.cpp <span style="color: grey">(0cabb85)</span></li>
<li>kdeui/dialogs/kedittoolbar.cpp <span style="color: grey">(d3b7a2b)</span></li>
<li>kdeui/dialogs/kinputdialog.cpp <span style="color: grey">(b8406ee)</span></li>
<li>kdeui/dialogs/klinkdialog.cpp <span style="color: grey">(bb06aac)</span></li>
<li>kdeui/dialogs/knewpassworddialog.cpp <span style="color: grey">(785f9da)</span></li>
<li>kdeui/dialogs/kpassworddialog.cpp <span style="color: grey">(1e0afab)</span></li>
<li>kdeui/dialogs/kshortcuteditwidget.cpp <span style="color: grey">(e922412)</span></li>
<li>kdeui/dialogs/kshortcutschemeseditor.cpp <span style="color: grey">(f159a1c)</span></li>
<li>kdeui/dialogs/kshortcutsdialog.cpp <span style="color: grey">(a375ac3)</span></li>
<li>kdeui/dialogs/kshortcutseditor.cpp <span style="color: grey">(991f458)</span></li>
<li>kdeui/dialogs/kshortcutseditordelegate.cpp <span style="color: grey">(60ddbcb)</span></li>
<li>kdeui/dialogs/kswitchlanguagedialog_p.cpp <span style="color: grey">(6846742)</span></li>
<li>kdeui/dialogs/ktip.cpp <span style="color: grey">(2adf019)</span></li>
<li>kdeui/findreplace/kfind.cpp <span style="color: grey">(0f6dedc)</span></li>
<li>kdeui/findreplace/kfinddialog.cpp <span style="color: grey">(081acd6)</span></li>
<li>kdeui/findreplace/kreplace.cpp <span style="color: grey">(61b33fd)</span></li>
<li>kdeui/fonts/kfontchooser.cpp <span style="color: grey">(bd1185f)</span></li>
<li>kdeui/fonts/kfontdialog.cpp <span style="color: grey">(efd6a35)</span></li>
<li>kdeui/fonts/kfontrequester.cpp <span style="color: grey">(260ac9c)</span></li>
<li>kdeui/itemviews/kbreadcrumbselectionmodel.cpp <span style="color: grey">(81e1b5d)</span></li>
<li>kdeui/itemviews/kdescendantsproxymodel.cpp <span style="color: grey">(ae571fb)</span></li>
<li>kdeui/itemviews/kextendableitemdelegate.cpp <span style="color: grey">(ceeca4a)</span></li>
<li>kdeui/itemviews/kfilterproxysearchline.cpp <span style="color: grey">(e1873e6)</span></li>
<li>kdeui/itemviews/kidentityproxymodel.cpp <span style="color: grey">(0c65759)</span></li>
<li>kdeui/itemviews/klinkitemselectionmodel.cpp <span style="color: grey">(5e7751f)</span></li>
<li>kdeui/itemviews/klistwidget.cpp <span style="color: grey">(5b6c3c6)</span></li>
<li>kdeui/itemviews/klistwidgetsearchline.cpp <span style="color: grey">(1478e86)</span></li>
<li>kdeui/itemviews/kselectionproxymodel.cpp <span style="color: grey">(eca2d78)</span></li>
<li>kdeui/itemviews/ktreewidgetsearchline.cpp <span style="color: grey">(a019213)</span></li>
<li>kdeui/itemviews/kviewstatesaver.cpp <span style="color: grey">(8418cfe)</span></li>
<li>kdeui/kernel/kapplication.cpp <span style="color: grey">(cc20f05)</span></li>
<li>kdeui/kernel/kclipboard.cpp <span style="color: grey">(0d97567)</span></li>
<li>kdeui/kernel/kstartupinfo.cpp <span style="color: grey">(2289177)</span></li>
<li>kdeui/notifications/ksystemtrayicon.cpp <span style="color: grey">(6ed337a)</span></li>
<li>kdeui/paged/kpageview.cpp <span style="color: grey">(b26f081)</span></li>
<li>kdeui/paged/kpageview_p.cpp <span style="color: grey">(5bc3fb2)</span></li>
<li>kdeui/paged/kpagewidget.cpp <span style="color: grey">(1a7c0ed)</span></li>
<li>kdeui/shortcuts/kglobalaccel.cpp <span style="color: grey">(f331ca4)</span></li>
<li>kdeui/sonnet/dialog.cpp <span style="color: grey">(90679c1)</span></li>
<li>kdeui/sonnet/dictionarycombobox.cpp <span style="color: grey">(769cee3)</span></li>
<li>kdeui/sonnet/highlighter.cpp <span style="color: grey">(3f478f0)</span></li>
<li>kdeui/sonnet/tests/backgroundtest.cpp <span style="color: grey">(092152e)</span></li>
<li>kdeui/sonnet/tests/test_dialog.cpp <span style="color: grey">(df68d25)</span></li>
<li>kdeui/sonnet/tests/test_highlighter.cpp <span style="color: grey">(1cea506)</span></li>
<li>kdeui/tests/kbuttongrouptest.cpp <span style="color: grey">(cc3fdee)</span></li>
<li>kdeui/tests/kcodecactiontest.cpp <span style="color: grey">(87862fa)</span></li>
<li>kdeui/tests/kcompletioncoretest.cpp <span style="color: grey">(49f8e42)</span></li>
<li>kdeui/tests/kcompletionuitest.cpp <span style="color: grey">(8d6a517)</span></li>
<li>kdeui/tests/kfadewidgeteffecttest.cpp <span style="color: grey">(23a820d)</span></li>
<li>kdeui/tests/kfindtest.cpp <span style="color: grey">(fdd112f)</span></li>
<li>kdeui/tests/khboxtest.cpp <span style="color: grey">(ff87b2d)</span></li>
<li>kdeui/tests/kiconeffecttest.cpp <span style="color: grey">(77131a8)</span></li>
<li>kdeui/tests/klineedittest.cpp <span style="color: grey">(0a222dc)</span></li>
<li>kdeui/tests/kmainwindowtest.cpp <span style="color: grey">(0af6d48)</span></li>
<li>kdeui/tests/kmanagerselectiontest.cpp <span style="color: grey">(6feb5c1)</span></li>
<li>kdeui/tests/kmodifierkeyinfotest.cpp <span style="color: grey">(26a62c3)</span></li>
<li>kdeui/tests/kpagewidgettest.cpp <span style="color: grey">(8ea825d)</span></li>
<li>kdeui/tests/kpassivepopuptest.cpp <span style="color: grey">(d81ac83)</span></li>
<li>kdeui/tests/kreplacetest.cpp <span style="color: grey">(b886f42)</span></li>
<li>kdeui/tests/kselectactiontest.cpp <span style="color: grey">(8ca804e)</span></li>
<li>kdeui/tests/kstatusbartest.cpp <span style="color: grey">(56d1412)</span></li>
<li>kdeui/tests/ktabwidgettest.cpp <span style="color: grey">(fc2bc0a)</span></li>
<li>kdeui/tests/ktoolbar_unittest.cpp <span style="color: grey">(123221b)</span></li>
<li>kdeui/tests/kwindowtest.cpp <span style="color: grey">(23788e8)</span></li>
<li>kdeui/tests/kxmlguitest.cpp <span style="color: grey">(f7ac542)</span></li>
<li>kdeui/tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp <span style="color: grey">(2a02928)</span></li>
<li>kdeui/tests/proxymodeltestapp/descendantpmwidget.cpp <span style="color: grey">(24e831f)</span></li>
<li>kdeui/tests/proxymodeltestapp/kreparentingproxymodel.cpp <span style="color: grey">(4a8017c)</span></li>
<li>kdeui/tests/proxymodeltestsuite/dynamictreemodel.cpp <span style="color: grey">(8b406f0)</span></li>
<li>kdeui/tests/proxymodeltestsuite/modelselector.cpp <span style="color: grey">(b3da5cc)</span></li>
<li>kdeui/tests/proxymodeltestsuite/modelspy.cpp <span style="color: grey">(ea88a85)</span></li>
<li>kdeui/tests/proxymodeltestsuite/modeltest.cpp <span style="color: grey">(5a5a39c)</span></li>
<li>kdeui/tests/proxymodeltestsuite/proxymodeltest.cpp <span style="color: grey">(b6c8977)</span></li>
<li>kdeui/tests/testmodelqueuedconnections.cpp <span style="color: grey">(bac4b76)</span></li>
<li>kdeui/tests/testplot_widget.cpp <span style="color: grey">(c139b7d)</span></li>
<li>kdeui/util/kcursor.cpp <span style="color: grey">(087d227)</span></li>
<li>kdeui/util/kmodifierkeyinfo.cpp <span style="color: grey">(4de09c7)</span></li>
<li>kdeui/util/kpassivepopup.cpp <span style="color: grey">(7e5637c)</span></li>
<li>kdeui/util/kwallet.cpp <span style="color: grey">(51c741a)</span></li>
<li>kdeui/util/kwallet_mac.cpp <span style="color: grey">(706ff74)</span></li>
<li>kdeui/widgets/kbuttongroup.cpp <span style="color: grey">(6d57c71)</span></li>
<li>kdeui/widgets/kcharselect.cpp <span style="color: grey">(905343a)</span></li>
<li>kdeui/widgets/kcmodule.cpp <span style="color: grey">(cf1fd6c)</span></li>
<li>kdeui/widgets/kcombobox.cpp <span style="color: grey">(4bde2d5)</span></li>
<li>kdeui/widgets/kcompletionbox.cpp <span style="color: grey">(6b9b050)</span></li>
<li>kdeui/widgets/kdatecombobox.cpp <span style="color: grey">(647afbc)</span></li>
<li>kdeui/widgets/kdatepicker.cpp <span style="color: grey">(7682949)</span></li>
<li>kdeui/widgets/kdatetable.cpp <span style="color: grey">(ccfc230)</span></li>
<li>kdeui/widgets/kdatetimewidget.cpp <span style="color: grey">(b1dcd58)</span></li>
<li>kdeui/widgets/kdatewidget.cpp <span style="color: grey">(07ba2df)</span></li>
<li>kdeui/widgets/keditlistbox.cpp <span style="color: grey">(576dba6)</span></li>
<li>kdeui/widgets/keditlistwidget.cpp <span style="color: grey">(39b56f3)</span></li>
<li>kdeui/widgets/khelpmenu.cpp <span style="color: grey">(e3917e5)</span></li>
<li>kdeui/widgets/khistorycombobox.cpp <span style="color: grey">(47c9828)</span></li>
<li>kdeui/widgets/klineedit.cpp <span style="color: grey">(701b8f1)</span></li>
<li>kdeui/widgets/kmainwindow.cpp <span style="color: grey">(41cef48)</span></li>
<li>kdeui/widgets/kmenubar.cpp <span style="color: grey">(948c229)</span></li>
<li>kdeui/widgets/kpixmapregionselectorwidget.cpp <span style="color: grey">(4e322a8)</span></li>
<li>kdeui/widgets/kpushbutton.cpp <span style="color: grey">(fd3ce65)</span></li>
<li>kdeui/widgets/krichtextwidget.cpp <span style="color: grey">(cf1e6c9)</span></li>
<li>kdeui/widgets/kshortcutwidget.cpp <span style="color: grey">(f8d93f2)</span></li>
<li>kdeui/widgets/ktabbar.cpp <span style="color: grey">(b9a790b)</span></li>
<li>kdeui/widgets/ktabwidget.cpp <span style="color: grey">(5b268d4)</span></li>
<li>kdeui/widgets/ktextedit.cpp <span style="color: grey">(9987707)</span></li>
<li>kdeui/widgets/ktimecombobox.cpp <span style="color: grey">(779c9ff)</span></li>
<li>kdeui/widgets/ktoolbar.cpp <span style="color: grey">(cce242b)</span></li>
<li>kdeui/widgets/kurllabel.cpp <span style="color: grey">(43b64cc)</span></li>
<li>kdeui/windowmanagement/kwindowsystem_win.cpp <span style="color: grey">(873c86f)</span></li>
<li>kdeui/windowmanagement/kwindowsystem_x11.cpp <span style="color: grey">(741393c)</span></li>
<li>kdeui/xmlgui/kmenumenuhandler_p.cpp <span style="color: grey">(cc3499e)</span></li>
<li>kdeui/xmlgui/ktoolbarhandler.cpp <span style="color: grey">(73a6a4e)</span></li>
<li>kdeui/xmlgui/kxmlguiwindow.cpp <span style="color: grey">(760b5d1)</span></li>
<li>kdewebkit/kwebpage.cpp <span style="color: grey">(9147023)</span></li>
<li>kfile/kdiroperator.cpp <span style="color: grey">(4def102)</span></li>
<li>kfile/kdirselectdialog.cpp <span style="color: grey">(4bc3f6f)</span></li>
<li>kfile/kfilefiltercombo.cpp <span style="color: grey">(deb57c8)</span></li>
<li>kfile/kfileplaceeditdialog.cpp <span style="color: grey">(a024ff0)</span></li>
<li>kfile/kfileplacesitem.cpp <span style="color: grey">(a06d340)</span></li>
<li>kfile/kfileplacesmodel.cpp <span style="color: grey">(96f6912)</span></li>
<li>kfile/kfileplacessharedbookmarks.cpp <span style="color: grey">(9cbdcf4)</span></li>
<li>kfile/kfileplacesview.cpp <span style="color: grey">(6a343b3)</span></li>
<li>kfile/kfilepreviewgenerator.cpp <span style="color: grey">(9c71ff8)</span></li>
<li>kfile/kfiletreeview.cpp <span style="color: grey">(d96263c)</span></li>
<li>kfile/kfilewidget.cpp <span style="color: grey">(960d6c4)</span></li>
<li>kfile/knewfilemenu.cpp <span style="color: grey">(fbb0e48)</span></li>
<li>kfile/kurlnavigator.cpp <span style="color: grey">(6a8525f)</span></li>
<li>kfile/kurlnavigatorbutton.cpp <span style="color: grey">(536e976)</span></li>
<li>kfile/kurlnavigatorplacesselector.cpp <span style="color: grey">(28ee9c3)</span></li>
<li>kfile/tests/kfileplacesmodeltest.cpp <span style="color: grey">(85625ca)</span></li>
<li>khtml/ecma/debugger/debugdocument.cpp <span style="color: grey">(78c7744)</span></li>
<li>khtml/ecma/debugger/debugwindow.cpp <span style="color: grey">(4438a1a)</span></li>
<li>khtml/ecma/debugger/scriptsdock.cpp <span style="color: grey">(be50629)</span></li>
<li>khtml/ecma/kjs_window.cpp <span style="color: grey">(92f3fcd)</span></li>
<li>khtml/ecma/xmlhttprequest.cpp <span style="color: grey">(d441e8d)</span></li>
<li>khtml/html/html_documentimpl.cpp <span style="color: grey">(5d60a21)</span></li>
<li>khtml/html/html_objectimpl.cpp <span style="color: grey">(1ee642e)</span></li>
<li>khtml/java/kjavaappletserver.cpp <span style="color: grey">(52e1790)</span></li>
<li>khtml/java/kjavaappletviewer.cpp <span style="color: grey">(92c33e3)</span></li>
<li>khtml/java/kjavaappletwidget.cpp <span style="color: grey">(7d433d4)</span></li>
<li>khtml/java/kjavadownloader.cpp <span style="color: grey">(eb5260e)</span></li>
<li>khtml/java/kjavaprocess.cpp <span style="color: grey">(ae06579)</span></li>
<li>khtml/khtml_ext.cpp <span style="color: grey">(66a2748)</span></li>
<li>khtml/khtml_pagecache.cpp <span style="color: grey">(f3b37e0)</span></li>
<li>khtml/khtml_part.cpp <span style="color: grey">(35a5785)</span></li>
<li>khtml/khtml_settings.cpp <span style="color: grey">(43d2ff8)</span></li>
<li>khtml/khtmlimage.cpp <span style="color: grey">(5738d85)</span></li>
<li>khtml/khtmlviewbarwidget.cpp <span style="color: grey">(1a54b34)</span></li>
<li>khtml/kmultipart/kmultipart.cpp <span style="color: grey">(a943806)</span></li>
<li>khtml/misc/loader.cpp <span style="color: grey">(38b623b)</span></li>
<li>khtml/rendering/media_controls.cpp <span style="color: grey">(fcf4682)</span></li>
<li>khtml/rendering/render_form.cpp <span style="color: grey">(aa59d3d)</span></li>
<li>khtml/rendering/render_frames.cpp <span style="color: grey">(c4046f3)</span></li>
<li>khtml/rendering/render_replaced.cpp <span style="color: grey">(9831cdb)</span></li>
<li>khtml/test_regression.cpp <span style="color: grey">(d4d43da)</span></li>
<li>khtml/test_regression_gui_window.cpp <span style="color: grey">(4a6022c)</span></li>
<li>khtml/testkhtml.cpp <span style="color: grey">(6be32c8)</span></li>
<li>khtml/tests/testkhtmlnew.cpp <span style="color: grey">(0ea8c71)</span></li>
<li>khtml/ui/findbar/khtmlfind.cpp <span style="color: grey">(16f7342)</span></li>
<li>khtml/ui/findbar/khtmlfindbar.cpp <span style="color: grey">(c3092a3)</span></li>
<li>kinit/kinit.cpp <span style="color: grey">(32cc1e8)</span></li>
<li>kinit/klauncher.cpp <span style="color: grey">(d8f86ca)</span></li>
<li>kinit/klauncher_main.cpp <span style="color: grey">(3422ee4)</span></li>
<li>kio/kfile/kacleditwidget.cpp <span style="color: grey">(f42a36f)</span></li>
<li>kio/kfile/kcommentwidget.cpp <span style="color: grey">(a2ff7f8)</span></li>
<li>kio/kfile/kdevicelistmodel.cpp <span style="color: grey">(1844bad)</span></li>
<li>kio/kfile/kfiledialog.cpp <span style="color: grey">(5c7dc85)</span></li>
<li>kio/kfile/kfilemetadataprovider.cpp <span style="color: grey">(f88a411)</span></li>
<li>kio/kfile/kfilemetadatareader.cpp <span style="color: grey">(9408adc)</span></li>
<li>kio/kfile/kfilemetainfowidget.cpp <span style="color: grey">(ce01dda)</span></li>
<li>kio/kfile/kfilesharedialog.cpp <span style="color: grey">(3e00d35)</span></li>
<li>kio/kfile/kicondialog.cpp <span style="color: grey">(f106182)</span></li>
<li>kio/kfile/kimagefilepreview.cpp <span style="color: grey">(8cee866)</span></li>
<li>kio/kfile/kmetaprops.cpp <span style="color: grey">(65c8dee)</span></li>
<li>kio/kfile/kopenwithdialog.cpp <span style="color: grey">(7033d88)</span></li>
<li>kio/kfile/kpreviewprops.cpp <span style="color: grey">(2aacc9e)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(98755de)</span></li>
<li>kio/kfile/kurlcombobox.cpp <span style="color: grey">(8d980fe)</span></li>
<li>kio/kfile/kurlrequester.cpp <span style="color: grey">(444ba7f)</span></li>
<li>kio/kio/accessmanagerreply_p.cpp <span style="color: grey">(942f0e5)</span></li>
<li>kio/kio/chmodjob.cpp <span style="color: grey">(939de2c)</span></li>
<li>kio/kio/copyjob.cpp <span style="color: grey">(306e60f)</span></li>
<li>kio/kio/delegateanimationhandler.cpp <span style="color: grey">(bf5ee2b)</span></li>
<li>kio/kio/deletejob.cpp <span style="color: grey">(6722b43)</span></li>
<li>kio/kio/directorysizejob.cpp <span style="color: grey">(3ca8599)</span></li>
<li>kio/kio/filejob.cpp <span style="color: grey">(98a9d06)</span></li>
<li>kio/kio/fileundomanager.cpp <span style="color: grey">(f580c29)</span></li>
<li>kio/kio/forwardingslavebase.cpp <span style="color: grey">(573fad2)</span></li>
<li>kio/kio/job.cpp <span style="color: grey">(94bffc1)</span></li>
<li>kio/kio/kautomount.cpp <span style="color: grey">(80f860f)</span></li>
<li>kio/kio/kdatatool.cpp <span style="color: grey">(ddd2698)</span></li>
<li>kio/kio/kdirlister.cpp <span style="color: grey">(ec3d622)</span></li>
<li>kio/kio/kdirmodel.cpp <span style="color: grey">(c8de5a3)</span></li>
<li>kio/kio/kfileshare.cpp <span style="color: grey">(6f77c59)</span></li>
<li>kio/kio/knfsshare.cpp <span style="color: grey">(e5bc9ce)</span></li>
<li>kio/kio/kpasswdserver.cpp <span style="color: grey">(0705dc5)</span></li>
<li>kio/kio/krun.cpp <span style="color: grey">(1ff6979)</span></li>
<li>kio/kio/ksambashare.cpp <span style="color: grey">(95b6c55)</span></li>
<li>kio/kio/kurlcompletion.cpp <span style="color: grey">(8b8c8a7)</span></li>
<li>kio/kio/metainfojob.cpp <span style="color: grey">(6fc6712)</span></li>
<li>kio/kio/netaccess.cpp <span style="color: grey">(b838382)</span></li>
<li>kio/kio/pastedialog.cpp <span style="color: grey">(9bd773d)</span></li>
<li>kio/kio/previewjob.cpp <span style="color: grey">(5635875)</span></li>
<li>kio/kio/renamedialog.cpp <span style="color: grey">(aa60a94)</span></li>
<li>kio/kio/scheduler.cpp <span style="color: grey">(6b36d9d)</span></li>
<li>kio/kio/skipdialog.cpp <span style="color: grey">(e65ea51)</span></li>
<li>kio/kssl/kcm/cacertificatespage.cpp <span style="color: grey">(c83b757)</span></li>
<li>kio/kssl/ksslkeygen.cpp <span style="color: grey">(93b0103)</span></li>
<li>kio/misc/kpac/discovery.cpp <span style="color: grey">(dfde7d2)</span></li>
<li>kio/misc/kpac/downloader.cpp <span style="color: grey">(8d9f7f3)</span></li>
<li>kio/tests/fileundomanagertest.cpp <span style="color: grey">(08db2a1)</span></li>
<li>kio/tests/jobremotetest.cpp <span style="color: grey">(9e0a4ff)</span></li>
<li>kio/tests/jobtest.cpp <span style="color: grey">(29ce641)</span></li>
<li>kio/tests/kdcopcheck.cpp <span style="color: grey">(e237327)</span></li>
<li>kio/tests/kdirlistertest.cpp <span style="color: grey">(a9a46cc)</span></li>
<li>kio/tests/kdirlistertest_gui.cpp <span style="color: grey">(14fc7ae)</span></li>
<li>kio/tests/kdirmodeltest.cpp <span style="color: grey">(d3ad365)</span></li>
<li>kio/tests/kfdtest.cpp <span style="color: grey">(225db2d)</span></li>
<li>kio/tests/kioslavetest.cpp <span style="color: grey">(5536abc)</span></li>
<li>kio/tests/previewtest.cpp <span style="color: grey">(7c8d62d)</span></li>
<li>kio/tests/speed.cpp <span style="color: grey">(056d081)</span></li>
<li>kioslave/http/http.cpp <span style="color: grey">(95dbe78)</span></li>
<li>kjsembed/examples/kjsconsole/console.cpp <span style="color: grey">(0bb5707)</span></li>
<li>kjsembed/examples/kjsconsole/numberedtextview.cpp <span style="color: grey">(2742597)</span></li>
<li>kjsembed/kjscmd/kjscmd.cpp <span style="color: grey">(8e88133)</span></li>
<li>knewstuff/knewstuff2/core/coreengine.cpp <span style="color: grey">(7aaf610)</span></li>
<li>knewstuff/knewstuff2/core/entryloader.cpp <span style="color: grey">(5ae425b)</span></li>
<li>knewstuff/knewstuff2/core/providerloader.cpp <span style="color: grey">(8ec0bef)</span></li>
<li>knewstuff/knewstuff2/core/security.cpp <span style="color: grey">(93497ed)</span></li>
<li>knewstuff/knewstuff2/dxs/dxs.cpp <span style="color: grey">(003a447)</span></li>
<li>knewstuff/knewstuff2/dxs/dxsengine.cpp <span style="color: grey">(f51be8c)</span></li>
<li>knewstuff/knewstuff2/dxs/soap.cpp <span style="color: grey">(9e3db65)</span></li>
<li>knewstuff/knewstuff2/engine.cpp <span style="color: grey">(ec046bf)</span></li>
<li>knewstuff/knewstuff2/ui/downloaddialog.cpp <span style="color: grey">(48ddc7f)</span></li>
<li>knewstuff/knewstuff2/ui/itemsmodel.cpp <span style="color: grey">(0651595)</span></li>
<li>knewstuff/knewstuff2/ui/itemsview.cpp <span style="color: grey">(1cd1120)</span></li>
<li>knewstuff/knewstuff2/ui/itemsviewdelegate.cpp <span style="color: grey">(2244bc6)</span></li>
<li>knewstuff/knewstuff2/ui/kdxsbutton.cpp <span style="color: grey">(79e0c02)</span></li>
<li>knewstuff/knewstuff2/ui/kdxscomments.cpp <span style="color: grey">(9d89bf7)</span></li>
<li>knewstuff/knewstuff2/ui/qasyncimage.cpp <span style="color: grey">(8568e1c)</span></li>
<li>knewstuff/knewstuff3/attica/atticaprovider.cpp <span style="color: grey">(90ae4db)</span></li>
<li>knewstuff/knewstuff3/core/engine.cpp <span style="color: grey">(55abc50)</span></li>
<li>knewstuff/knewstuff3/core/security.cpp <span style="color: grey">(7d44ba4)</span></li>
<li>knewstuff/knewstuff3/core/xmlloader.cpp <span style="color: grey">(8633466)</span></li>
<li>knewstuff/knewstuff3/downloadwidget.cpp <span style="color: grey">(9f4c774)</span></li>
<li>knewstuff/knewstuff3/staticxml/staticxmlprovider.cpp <span style="color: grey">(4a81f3f)</span></li>
<li>knewstuff/knewstuff3/ui/imageloader.cpp <span style="color: grey">(cc63f32)</span></li>
<li>knewstuff/knewstuff3/ui/itemsgridviewdelegate.cpp <span style="color: grey">(56ccb53)</span></li>
<li>knewstuff/knewstuff3/ui/itemsviewdelegate.cpp <span style="color: grey">(95553e5)</span></li>
<li>knewstuff/knewstuff3/upload/atticahelper.cpp <span style="color: grey">(f91d4a6)</span></li>
<li>knewstuff/knewstuff3/uploaddialog.cpp <span style="color: grey">(44c7ea3)</span></li>
<li>knewstuff/tests/knewstuff2_cache.cpp <span style="color: grey">(070129b)</span></li>
<li>knewstuff/tests/knewstuff2_download.cpp <span style="color: grey">(4033e8a)</span></li>
<li>knewstuff/tests/knewstuff2_test.cpp <span style="color: grey">(104653c)</span></li>
<li>knotify/config/knotifyconfigwidget.cpp <span style="color: grey">(60f3a51)</span></li>
<li>knotify/config/knotifyeventlist.cpp <span style="color: grey">(c5d0b15)</span></li>
<li>knotify/tests/knotifytestwindow.cpp <span style="color: grey">(0e0f909)</span></li>
<li>kparts/browserextension.cpp <span style="color: grey">(bd65122)</span></li>
<li>kparts/browserrun.cpp <span style="color: grey">(b8cc39d)</span></li>
<li>kparts/mainwindow.cpp <span style="color: grey">(bd21a54)</span></li>
<li>kparts/part.cpp <span style="color: grey">(b9c8be5)</span></li>
<li>kparts/partmanager.cpp <span style="color: grey">(2b0e027)</span></li>
<li>kparts/scriptableextension.cpp <span style="color: grey">(38c8201)</span></li>
<li>kparts/tests/notepad.cpp <span style="color: grey">(faa591e)</span></li>
<li>kparts/tests/testmainwindow.cpp <span style="color: grey">(d85abc2)</span></li>
<li>kpty/tests/kptyprocesstest.cpp <span style="color: grey">(e5aea68)</span></li>
<li>kross/core/actioncollection.cpp <span style="color: grey">(4c10b69)</span></li>
<li>kross/modules/form.cpp <span style="color: grey">(fbb2828)</span></li>
<li>kross/ui/model.cpp <span style="color: grey">(a66ef29)</span></li>
<li>kross/ui/view.cpp <span style="color: grey">(f8dab88)</span></li>
<li>kutils/kcmodulecontainer.cpp <span style="color: grey">(7a72eec)</span></li>
<li>kutils/kcmultidialog.cpp <span style="color: grey">(5e11be2)</span></li>
<li>kutils/kemoticons/kemoticons.cpp <span style="color: grey">(b37b0d8)</span></li>
<li>kutils/kemoticons/tests/main.cpp <span style="color: grey">(f993cd2)</span></li>
<li>kutils/ksettings/componentsdialog.cpp <span style="color: grey">(94c4be8)</span></li>
<li>kutils/ksettings/dialog.cpp <span style="color: grey">(03a3104)</span></li>
<li>kutils/ksettings/dispatcher.cpp <span style="color: grey">(c5b88d6)</span></li>
<li>kutils/ksettings/pluginpage.cpp <span style="color: grey">(be6a7ba)</span></li>
<li>nepomuk/core/nepomukmainmodel.cpp <span style="color: grey">(7e48a79)</span></li>
<li>nepomuk/query/queryserviceclient.cpp <span style="color: grey">(cd402e1)</span></li>
<li>nepomuk/test/ratingpaintertestwidget.cpp <span style="color: grey">(8d87798)</span></li>
<li>nepomuk/ui/kedittagsdialog.cpp <span style="color: grey">(dc5ace9)</span></li>
<li>nepomuk/ui/ktagcloudwidget.cpp <span style="color: grey">(8914827)</span></li>
<li>nepomuk/ui/ktagdisplaywidget.cpp <span style="color: grey">(e7f53bd)</span></li>
<li>nepomuk/ui/nepomukmassupdatejob.cpp <span style="color: grey">(cf7a9c6)</span></li>
<li>nepomuk/ui/tagwidget.cpp <span style="color: grey">(f5254b4)</span></li>
<li>nepomuk/utils/daterangeselectionwidget.cpp <span style="color: grey">(a3c4979)</span></li>
<li>nepomuk/utils/facetwidget.cpp <span style="color: grey">(0a443fe)</span></li>
<li>nepomuk/utils/searchwidget.cpp <span style="color: grey">(de609ab)</span></li>
<li>plasma/applet.cpp <span style="color: grey">(6db48db)</span></li>
<li>plasma/containment.cpp <span style="color: grey">(6840b64)</span></li>
<li>plasma/datacontainer.cpp <span style="color: grey">(33d8157)</span></li>
<li>plasma/dataengine.cpp <span style="color: grey">(259ac2e)</span></li>
<li>plasma/dataenginemanager.cpp <span style="color: grey">(988fe76)</span></li>
<li>plasma/deprecated/animator.cpp <span style="color: grey">(03d40d6)</span></li>
<li>plasma/extenders/extender.cpp <span style="color: grey">(74de8c9)</span></li>
<li>plasma/private/associatedapplicationmanager.cpp <span style="color: grey">(9da0fd2)</span></li>
<li>plasma/private/kineticscroll.cpp <span style="color: grey">(fe16228)</span></li>
<li>plasma/private/qtjolie-branch/qtjolie/serverthread.cpp <span style="color: grey">(a609e2f)</span></li>
<li>plasma/private/qtjolie-branch/tests/calculatorservice.cpp <span style="color: grey">(23dd972)</span></li>
<li>plasma/private/remoteservice.cpp <span style="color: grey">(6c15fd1)</span></li>
<li>plasma/private/serviceprovider.cpp <span style="color: grey">(6f1d905)</span></li>
<li>plasma/private/storage.cpp <span style="color: grey">(717a346)</span></li>
<li>plasma/scripting/wallpaperscript.cpp <span style="color: grey">(edca37d)</span></li>
<li>plasma/tests/testcontainmentactionsplugin/test.cpp <span style="color: grey">(05066b6)</span></li>
<li>plasma/view.cpp <span style="color: grey">(c4aa835)</span></li>
<li>plasma/wallpaper.cpp <span style="color: grey">(35d744f7)</span></li>
<li>plasma/widgets/combobox.cpp <span style="color: grey">(d52eb0a)</span></li>
<li>plasma/widgets/lineedit.cpp <span style="color: grey">(d000439)</span></li>
<li>plasma/widgets/videowidget.cpp <span style="color: grey">(d79a9fd)</span></li>
<li>plasma/widgets/webview.cpp <span style="color: grey">(f85881c)</span></li>
<li>security/crypto/certexport.cpp <span style="color: grey">(b4933e7)</span></li>
<li>security/crypto/crypto.cpp <span style="color: grey">(465f1dd)</span></li>
<li>solid/solid/acadapter.cpp <span style="color: grey">(2601600)</span></li>
<li>solid/solid/backends/fakehw/fakedevice.cpp <span style="color: grey">(d727492)</span></li>
<li>solid/solid/backends/fakehw/fakegenericinterface.cpp <span style="color: grey">(8f4b8e2)</span></li>
<li>solid/solid/backends/fakehw/fakestorageaccess.cpp <span style="color: grey">(d8d6ca7)</span></li>
<li>solid/solid/backends/fstab/fstabhandling.cpp <span style="color: grey">(68db263)</span></li>
<li>solid/solid/backends/fstab/fstabstorageaccess.cpp <span style="color: grey">(e8d519d)</span></li>
<li>solid/solid/backends/hal/halacadapter.cpp <span style="color: grey">(0ca1f88)</span></li>
<li>solid/solid/backends/hal/halbattery.cpp <span style="color: grey">(0d95c36)</span></li>
<li>solid/solid/backends/hal/halbutton.cpp <span style="color: grey">(1669fde)</span></li>
<li>solid/solid/backends/hal/halcdrom.cpp <span style="color: grey">(fe54b5a)</span></li>
<li>solid/solid/backends/hal/haldevice.cpp <span style="color: grey">(528b183)</span></li>
<li>solid/solid/backends/hal/halfstabhandling.cpp <span style="color: grey">(32a7031)</span></li>
<li>solid/solid/backends/hal/halgenericinterface.cpp <span style="color: grey">(0dd2f03)</span></li>
<li>solid/solid/backends/hal/halmanager.cpp <span style="color: grey">(7208c52)</span></li>
<li>solid/solid/backends/hal/halstorageaccess.cpp <span style="color: grey">(d280013)</span></li>
<li>solid/solid/backends/kupnp/kupnpmanager.cpp <span style="color: grey">(18cf9af)</span></li>
<li>solid/solid/backends/udev/udevgenericinterface.cpp <span style="color: grey">(174beec)</span></li>
<li>solid/solid/backends/udisks/udisksgenericinterface.cpp <span style="color: grey">(55b60dd)</span></li>
<li>solid/solid/backends/udisks/udisksopticaldrive.cpp <span style="color: grey">(4ed0c80)</span></li>
<li>solid/solid/backends/udisks/udisksstorageaccess.cpp <span style="color: grey">(f16b277)</span></li>
<li>solid/solid/backends/upnp/upnpinternetgateway.cpp <span style="color: grey">(be97754)</span></li>
<li>solid/solid/backends/wmi/wmiacadapter.cpp <span style="color: grey">(e66e426)</span></li>
<li>solid/solid/backends/wmi/wmibattery.cpp <span style="color: grey">(cbd3ce7)</span></li>
<li>solid/solid/backends/wmi/wmibutton.cpp <span style="color: grey">(575afe1)</span></li>
<li>solid/solid/backends/wmi/wmicdrom.cpp <span style="color: grey">(de95621)</span></li>
<li>solid/solid/backends/wmi/wmigenericinterface.cpp <span style="color: grey">(b590d3a)</span></li>
<li>solid/solid/backends/wmi/wmistorageaccess.cpp <span style="color: grey">(32d6c01)</span></li>
<li>solid/solid/battery.cpp <span style="color: grey">(9d05009)</span></li>
<li>solid/solid/button.cpp <span style="color: grey">(05cdb8f)</span></li>
<li>solid/solid/device.cpp <span style="color: grey">(b168139)</span></li>
<li>solid/solid/devicemanager.cpp <span style="color: grey">(59f32a7)</span></li>
<li>solid/solid/genericinterface.cpp <span style="color: grey">(1f27725)</span></li>
<li>solid/solid/internetgateway.cpp <span style="color: grey">(9f0ceb2)</span></li>
<li>solid/solid/networking.cpp <span style="color: grey">(a838b98)</span></li>
<li>solid/solid/opticaldrive.cpp <span style="color: grey">(5249331)</span></li>
<li>solid/solid/storageaccess.cpp <span style="color: grey">(2a47c2f)</span></li>
<li>solid/tests/halbasictest.cpp <span style="color: grey">(cef8c84)</span></li>
<li>solid/tests/networkingclient.cpp <span style="color: grey">(ffdaafa)</span></li>
<li>solid/tests/solidhwtest.cpp <span style="color: grey">(8cdcb1f)</span></li>
<li>solid/tests/solidnettestdbusservice.cpp <span style="color: grey">(0946cfe)</span></li>
<li>threadweaver/Examples/Jobs/Jobs.cpp <span style="color: grey">(08347cb)</span></li>
<li>threadweaver/Examples/Jobs/WeaverObserverTest.cpp <span style="color: grey">(05c739e)</span></li>
<li>threadweaver/Examples/QProcessJob/MainWindow.cpp <span style="color: grey">(8f70171)</span></li>
<li>threadweaver/Examples/SMIV/SMIV.cpp <span style="color: grey">(41ac2d0)</span></li>
<li>threadweaver/Examples/SMIV/SMIVItem.cpp <span style="color: grey">(af252ba)</span></li>
<li>threadweaver/Tests/DeleteTest.cpp <span style="color: grey">(112fe25)</span></li>
<li>threadweaver/Tests/JobTests.cpp <span style="color: grey">(6f0b38a)</span></li>
<li>threadweaver/Tests/QueueTests.cpp <span style="color: grey">(f46c534)</span></li>
<li>threadweaver/Weaver/Job.cpp <span style="color: grey">(6076d22)</span></li>
<li>threadweaver/Weaver/Thread.cpp <span style="color: grey">(5bcdd26)</span></li>
<li>threadweaver/Weaver/ThreadWeaver.cpp <span style="color: grey">(121bec1)</span></li>
<li>threadweaver/Weaver/WeaverImpl.cpp <span style="color: grey">(a8dc600)</span></li>
<li>threadweaver/WeaverGui/WeaverThreadGrid.cpp <span style="color: grey">(f0622d0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103728/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>