<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103882/">http://git.reviewboard.kde.org/r/103882/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 92e8ec0bf91ceead579dd469d1950cebbc6083f8 by Sebastian Trueg to branch KDE/4.8.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 8th, 2012, 9:56 p.m., Sebastian Trueg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Sebastian Trueg.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2012, 9:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem is fairly simple: I needed to create previews for directory items in a custom KIO slave. Writing the ThumbCreator was simple. But it got never called. The reason is that the thumbnail kio slave always uses its own directory thumbnailing method for folders if the plugin name is not specified in the metadata. The PreviewJob on the other hand does only specify the "plugin" metadata field for "local" ThumbCreators; remote ThumbCreators are only checked for existance.
This patch fixes that by first checking for a specialized ThumbCreator plugin by protocol and then falling back to the old way of detection my mime-type.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on my custom KIO slave: perfect thumbnails. Thumbnails for everything else still working fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/previewjob.cpp <span style="color: grey">(5635875)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103882/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>