<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103829/">http://git.reviewboard.kde.org/r/103829/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AFAIK, changing the order of virtual member functions might break binary compatibility:
http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++</pre>
<br />
<p>- Frank</p>
<br />
<p>On January 30th, 2012, 8:57 p.m., Laszlo Papp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Laszlo Papp.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2012, 8:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to the kconfig-xt example [1], it seems to me we need to call this
method for settings changing. Therefore, it is not enough to just set the
certain properties separately. I currently need to wrap this writeConfig()
method in a helper class in order to get an invokable or slot version.
There are at least two ways of addressing the issue in question:
1) Make the current method Q_INVOKABLE
2) Make the method actually a slot
I personally chose the second alternative since the method already returns
void, thus a potential candidate for being a slot. According to the Qt
documentation, it is not a problem for having a virtual (public) slot:
"You can also define slots to be virtual, which we have found quite useful in
practice."
[1] http://techbase.kde.org/Development/Tutorials/Using_KConfig_XT#Example</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on Archlinux for building only.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/config/kcoreconfigskeleton.h <span style="color: grey">(b42ff22)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103829/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>