<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103638/">http://git.reviewboard.kde.org/r/103638/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 22nd, 2012, 9:06 a.m., <b>Erik Sigra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">giving yourself a ship it kind of destroys the idea behind review board.
>From my side there is a clear "NO" for everything KWin related. So why? Let's consider for example atoms.h. I just used git blame and well the includes were last touched in 2007. So for about 5 years nobody cared about it. This means in my opinion that there is no reason to try to fix what is not broken. Yes being able to do a final build would be nice, but it seems not to be used.
Furthermore I don't like changes which would "fix" something that has been broken for years without anybody caring about it. It is quite clear that this will break again (especially in a component like KWin which has to work with X). There is no way to ensure that the build option does not break again. So why try to fix in the first place?
If there is a clear way to test final builds (e.g. on build.kde.org) I'm all for accepting a sensible patch to make KWin build with final option. But I'm not going to accept a partial fix.</pre>
<br />
<p>- Martin</p>
<br />
<p>On January 15th, 2012, 12:53 p.m., Erik Sigra wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and Hugo Pereira Da Costa.</div>
<div>By Erik Sigra.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2012, 12:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add #include <fixx11h.h> in some places where it was missing. This improves buildability.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcminit/main.cpp <span style="color: grey">(68bfb05)</span></li>
<li>kcontrol/access/kaccess.h <span style="color: grey">(c364b25)</span></li>
<li>kcontrol/access/kcmaccess.cpp <span style="color: grey">(64a6803)</span></li>
<li>kcontrol/bell/bell.cpp <span style="color: grey">(3d9395f)</span></li>
<li>kcontrol/fonts/fonts.cpp <span style="color: grey">(61886d4)</span></li>
<li>kcontrol/input/kapplymousetheme.cpp <span style="color: grey">(c9bc511)</span></li>
<li>kcontrol/input/main.cpp <span style="color: grey">(0f9f33a)</span></li>
<li>kcontrol/input/mouse.cpp <span style="color: grey">(cebb174)</span></li>
<li>kcontrol/input/xcursor/legacytheme.cpp <span style="color: grey">(28d7f2a)</span></li>
<li>kcontrol/input/xcursor/previewwidget.cpp <span style="color: grey">(aff149b)</span></li>
<li>kcontrol/input/xcursor/thememodel.cpp <span style="color: grey">(d69dde0)</span></li>
<li>kcontrol/input/xcursor/themepage.cpp <span style="color: grey">(0f678ed)</span></li>
<li>kcontrol/input/xcursor/xcursortheme.cpp <span style="color: grey">(2fc7504)</span></li>
<li>kcontrol/keyboard/kcmmisc.cpp <span style="color: grey">(382f026)</span></li>
<li>kcontrol/keyboard/keyboard_hardware.cpp <span style="color: grey">(9f9c026)</span></li>
<li>kcontrol/keyboard/xinput_helper.cpp <span style="color: grey">(2971d20)</span></li>
<li>kcontrol/kfontinst/lib/FcEngine.cpp <span style="color: grey">(8b74fce)</span></li>
<li>kcontrol/krdb/krdb.cpp <span style="color: grey">(92d84e9)</span></li>
<li>kcontrol/randr/krandrapp.cpp <span style="color: grey">(af53671)</span></li>
<li>kcontrol/randr/module/randrpolltest.cpp <span style="color: grey">(30d689e)</span></li>
<li>kcontrol/style/kcmstyle.cpp <span style="color: grey">(b8f46be)</span></li>
<li>kdm/kcm/background/bgrender.cpp <span style="color: grey">(17cf33d)</span></li>
<li>kdm/kfrontend/krootimage.cpp <span style="color: grey">(e4ddc85)</span></li>
<li>khotkeys/libkhotkeysprivate/actions/keyboard_input_action.cpp <span style="color: grey">(b3b1ec3)</span></li>
<li>khotkeys/libkhotkeysprivate/triggers/gestures.cpp <span style="color: grey">(e70c074)</span></li>
<li>khotkeys/libkhotkeysprivate/windows_handler.cpp <span style="color: grey">(eb02374)</span></li>
<li>kinfocenter/Modules/base/os_base.h <span style="color: grey">(9c903ea)</span></li>
<li>kinfocenter/Modules/opengl/opengl.cpp <span style="color: grey">(7df2b17)</span></li>
<li>klipper/klipper.cpp <span style="color: grey">(aafe616)</span></li>
<li>krunner/krunnerdialog.cpp <span style="color: grey">(007887f)</span></li>
<li>krunner/lock/lockprocess.cc <span style="color: grey">(65c7f1d)</span></li>
<li>krunner/screensaver/xautolock.cpp <span style="color: grey">(7124215)</span></li>
<li>krunner/startupid.cpp <span style="color: grey">(a436183)</span></li>
<li>kscreensaver/libkscreensaver/kscreensaver.cpp <span style="color: grey">(55bcbea)</span></li>
<li>ksmserver/fadeeffect.h <span style="color: grey">(8d45ebc)</span></li>
<li>ksmserver/fadeeffect.cpp <span style="color: grey">(8b94834)</span></li>
<li>ksmserver/kcheckrunning.cpp <span style="color: grey">(f0648fc)</span></li>
<li>ksmserver/legacy.cpp <span style="color: grey">(62a4672)</span></li>
<li>ksmserver/logouteffect.cpp <span style="color: grey">(a2fc060)</span></li>
<li>ksplash/ksplashqml/SplashApp.h <span style="color: grey">(9b63c4e)</span></li>
<li>ksplash/ksplashqml/main.cpp <span style="color: grey">(d59bff8)</span></li>
<li>ksplash/simple/main.cpp <span style="color: grey">(0e730bf)</span></li>
<li>kstyles/oxygen/oxygenshadowhelper.cpp <span style="color: grey">(28cc651)</span></li>
<li>kstyles/oxygen/oxygenstylehelper.cpp <span style="color: grey">(24710cd)</span></li>
<li>ksystraycmd/main.cpp <span style="color: grey">(9a72389)</span></li>
<li>kwin/atoms.h <span style="color: grey">(95e1bde)</span></li>
<li>kwin/clients/b2/b2client.cpp <span style="color: grey">(6b52996)</span></li>
<li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: grey">(cd94eb4)</span></li>
<li>kwin/clients/oxygen/oxygensizegrip.cpp <span style="color: grey">(221ee74)</span></li>
<li>kwin/effects/resize/resize.cpp <span style="color: grey">(84bdd7f)</span></li>
<li>kwin/effects/showfps/showfps.cpp <span style="color: grey">(5161401)</span></li>
<li>kwin/effects/showpaint/showpaint.cpp <span style="color: grey">(f689b1c)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: grey">(a3d4256)</span></li>
<li>kwin/kcmkwin/kwinoptions/mouse.cpp <span style="color: grey">(51a80f9)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: grey">(30c94c0)</span></li>
<li>kwin/killer/killer.cpp <span style="color: grey">(d37a654)</span></li>
<li>kwin/killwindow.cpp <span style="color: grey">(57e15e5)</span></li>
<li>kwin/libkwineffects/kwinglobals.cpp <span style="color: grey">(575813e)</span></li>
<li>kwin/opengltest/opengltest.cpp <span style="color: grey">(eda7b51)</span></li>
<li>kwin/outline.cpp <span style="color: grey">(6ef499c)</span></li>
<li>kwin/overlaywindow.h <span style="color: grey">(14d2d58)</span></li>
<li>kwin/tabbox/tabboxhandler.cpp <span style="color: grey">(e91ea71)</span></li>
<li>kwin/tools/decobenchmark/preview.cpp <span style="color: grey">(429cbd2)</span></li>
<li>kwin/tools/test_gravity.cpp <span style="color: grey">(4ddb136)</span></li>
<li>kwin/utils.cpp <span style="color: grey">(a9abc5d)</span></li>
<li>kwin/workspace.h <span style="color: grey">(40562d4)</span></li>
<li>libs/kephal/service/xrandr12/randrdisplay.h <span style="color: grey">(3a6392c)</span></li>
<li>libs/kworkspace/kdisplaymanager.cpp <span style="color: grey">(28fabfc)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: grey">(7abd8fc)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp <span style="color: grey">(4257202)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.cpp <span style="color: grey">(1826512)</span></li>
<li>plasma/generic/dataengines/mouse/cursornotificationhandler.h <span style="color: grey">(7b4d3eb)</span></li>
<li>plasma/netbook/shell/plasmaapp.cpp <span style="color: grey">(22c54b2)</span></li>
<li>powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp <span style="color: grey">(a16bf7e)</span></li>
<li>powerdevil/daemon/backends/upower/xrandrbrightness.h <span style="color: grey">(875c667)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103638/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>