<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103719/">http://git.reviewboard.kde.org/r/103719/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 18th, 2012, 3:39 p.m., <b>Jeremy Paul Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me as long as we aren't trying to keep BIC in frameworks. If we are, a duplicate method with KConfigSkeleton that simply calls this new method should be added to keep BC.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We are definitely not keeping BC in frameworks. What, with splitting code into different libs, moving code around, etc. So no issue here.</pre>
<br />
<p>- David</p>
<br />
<p>On January 17th, 2012, 9:28 p.m., Laszlo Papp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Jeremy Paul Whiting.</div>
<div>By Laszlo Papp.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2012, 9:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use case: there are applications, like kanagram, which would be nice to have
running on several platforms, as in handsets; for instance Harmattan on N9. It
would be nice to use the same settings code generation in certain cases for all
the platforms. The additions of KConfigSkeleton on the top of
KCoreConfigSkeleton are the font and color settings which are currently not
used in couple of KDE applications. Hence, it should not be mandatory. The
kdeui module is unlikely welcome on mobile platforms, especially in appstores
with its sizes and complexity for no real need.
KConfigDialogManager has apparently already two constructors (ie.: the need
already arised previously for such an approach); one with KConfigSkeleton
argument type, and yet another with KCoreConfigSkeleton. It looks like a
situation where the KCoreConfigSkeleton version was added for good.
The KConfigDialog constructor does not handle KCoreConfigSkeleton argument
type yet; it has probably somehow been missed so far. Changing the current
constructor to KCoreConfigSkeleton usage is a good way because it does not
cause any API break; a simple recompilation is enough in client applications.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build test on Linux</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kconfigdialog.h <span style="color: grey">(2ac0eda)</span></li>
<li>kdeui/dialogs/kconfigdialog.cpp <span style="color: grey">(e815e54)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103719/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>