<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103716/">http://git.reviewboard.kde.org/r/103716/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 17th, 2012, 10:28 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> "The kdeui module is unlikely welcome on mobile platforms"
Why is this review about adding stuff to kdeui, then? I don't get it. Either you're using it or you're not using it -- or the real reason is core/gui split in your libs/apps, which would be a valid point.</pre>
</blockquote>
<p>On January 18th, 2012, 5:57 a.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The desktop application uses kdeui.
KConfigDialog (QWidget *parent, const QString &name, KConfigSkeleton *config) -> It is now impossible to generate only one settings class inheriting KCoreConfigSkeleton, and use that in each frontend. I would not like to generate distinct settings classes without no real reasons.
Also, I discarded this patch because it is possible to make this API addition to 4.X. See my patch in frameworks.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is impossible to make this API addition to 4.X*</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On January 17th, 2012, 3:54 p.m., Laszlo Papp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Jeremy Paul Whiting.</div>
<div>By Laszlo Papp.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2012, 3:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use case: there are applications like kanagram which would be nice to have
running on several platforms, like handsets; for instance Harmattan on N9. It
would be nice to use the same settings code generation in certain cases for all
the platforms since the additions of KConfigSkeleton on the top of
KCoreConfigSkeleton are the font and color settings. These are currently not
used in many KDE applications. Hence, it should not be mandatory. The kdeui
module is unlikely welcome on mobile platforms, especially in appstores with
its sizes and complexity for no real need.
KConfigDialogManager has apparently already two constructors; one with
KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It
looks like a situation where the KCoreConfigSkeleton version was added later.
KConfigDialog does not have a constructor yet with KCoreConfigSkeleton argument
type yet; it has probably somehow been missed so far. Changing the current
constructor to KCoreConfigSkeleton usage is not possible in the 4.X major
version because of the consequences (ABI breakage). Thereby, the freshly
replacated constructor. The proper fix can be filed against frameworks where
there is only one, and properly working constructor.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On Archlinux (build test only)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kconfigdialog.h <span style="color: grey">(2ac0eda)</span></li>
<li>kdeui/dialogs/kconfigdialog.cpp <span style="color: grey">(e815e54)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103716/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>