<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103684/">http://git.reviewboard.kde.org/r/103684/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- David</p>
<br />
<p>On January 12th, 2012, 6:14 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2012, 6:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If a user enters, www.kde.org, in the URL location link file creation dialog, then the generated .desktop file entry would contain a URL entry without a scheme and as a result opening the link in Konqueror fails. Moreover, the code that attempts to determine the icon to associate with the newly created link file also fails to obtain the proper icon because of the missing scheme. The attached patch addresses both those issues by filtering the user input using the shorturifilter. Note that this problem was discovered while evaluting the afforementioned bug report.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=224142">224142</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/knewfilemenu.cpp <span style="color: grey">(07db5b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103684/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>