<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103602/">http://git.reviewboard.kde.org/r/103602/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 1st, 2012, 11:08 p.m., <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why the need for a new slot that connects to urlChanged ? Would simply quoting the user selected text in KOpenWithDialog::slotSelected not suffice ?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AFAICS, KOpenWithDialog::slotSelected is used for setting the contents of the line edit when picking an item from the KApplicationView rather than the file dialog. Unlike the paths returned by the file dialog, these should already be properly quoted.</pre>
<br />
<p>- Ingomar</p>
<br />
<p>On January 1st, 2012, 9:49 p.m., Ingomar Wesp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Ingomar Wesp.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2012, 9:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KOpenWithDialog expects the input in its line edit to be shell-quoted. Currently, however, when the user picks a path via the provided file dialog, whitespace and other special characters in the path are inserted verbatim. This leads to an error when the user tries to select an executable whose path contains such characters.
This tiny patch addresses the issue by adding a private slot that runs all paths coming from the file dialog through KShell::quoteArg().
I believe this solution is better than the one I originally proposed in the linked bug report, since it avoids the ambiguity of having to guess whether whitespace belongs to the path or an argument to the executable.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=281952">281952</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/kopenwithdialog.h <span style="color: grey">(86c02ab)</span></li>
<li>kio/kfile/kopenwithdialog.cpp <span style="color: grey">(b5ebbbf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103602/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>