<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103245/">http://git.reviewboard.kde.org/r/103245/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Dawit Alemayehu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KPasswdServer currently processes requests to prompt the user for passwords serially, i.e. one request at a time even if those requests came two totally different applications. Unfortunately that results one application waiting on a completely unrelated application to receive authorization information, which IMHO is unacceptable.
The commit that caused this problem was a4cc5583 and its intent was to address the issue 2 or more password dialogs being shown at the same time. The attached patch modifies that commit so that processRequest will handle requests so long as
#1. The request comes from two separate window ids.
#2. There is no pending prompt for the requested key (read: host+port).
So long as the above two conditions are met, the password prompt will be shown as required. This fixes a bug report, which I cannot find at the moment, where attempting to log into an sftp server in one Konqueror instance prevented the user from logging into a router admin interface in a completely different Konqueror instance.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attempt to log into two different sites from two different applications of two different instances of the same application.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpasswdserver/kpasswdserver.h <span style="color: grey">(351cb7c)</span></li>
<li>kpasswdserver/kpasswdserver.cpp <span style="color: grey">(cc8ded2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103245/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>