<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103165/">http://git.reviewboard.kde.org/r/103165/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103165/diff/1/?file=41334#file41334line663" style="color: black; font-weight: bold; text-decoration: underline;">kutils/kpluginselector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QSize KPluginSelector::Private::PluginDelegate::sizeHint(const QStyleOptionViewItem &option, const QModelIndex &index) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">663</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">pluginSelector_d</span><span class="o">-></span><span class="n">showIcons</span> <span class="o">?</span> <span class="n">KIconLoader</span><span class="o">::</span><span class="n">SizeMedium</span> <span class="o">:</span> <span class="mi">0</span> <span class="o">+</span> <span class="n">MARGIN</span> <span class="o">*</span> <span class="n">i</span> <span class="o">+</span> <span class="n">pushButton</span><span class="o">-></span><span class="n">sizeHint</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span class="o">*</span> <span class="n">j</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">663</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">pluginSelector_d</span><span class="o">-></span><span class="n">showIcons</span> <span class="o">?</span> <span class="n">KIconLoader</span><span class="o">::</span><span class="n">SizeMedium</span> <span class="o">:</span> <span class="p"><span class="hl">(</span></span><span class="mi">0</span> <span class="o">+</span> <span class="n">MARGIN</span> <span class="o">*</span> <span class="n">i</span> <span class="o">+</span> <span class="n">pushButton</span><span class="o">-></span><span class="n">sizeHint</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span class="o">*</span> <span class="n">j</span><span class="p"><span class="hl">)</span>,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"></pre>
</div>
<br />
<p>- David</p>
<br />
<p>On November 17th, 2011, 11:41 a.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2011, 11:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Trivial c++ fixes for some warnings of clang++ (2.99.9999)
memset the structure size, not the pointer size (fortunately, the structure size is greater than pointer size in this case).
remove double parenthesis
change false to 0 as pointer parameter
use parenthesis to clarify preference between ? and +
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still compiles with g++</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/sycoca/kmemfile.cpp <span style="color: grey">(a466bde)</span></li>
<li>kdeui/fonts/kfontchooser.cpp <span style="color: grey">(541f7db)</span></li>
<li>kdeui/tests/ktabwidgettest.cpp <span style="color: grey">(fdc3161)</span></li>
<li>kross/modules/form.cpp <span style="color: grey">(5e260c1)</span></li>
<li>kutils/kemoticons/kemoticonstheme.cpp <span style="color: grey">(c145741)</span></li>
<li>kutils/kpluginselector.cpp <span style="color: grey">(0a39fcc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103165/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>