<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103160/">http://git.reviewboard.kde.org/r/103160/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 17th, 2011, 9:20 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks very nice and thorough.
as for branch: it's a bug fix for sure and should go into the KDE/4.7 branch. that gets merged into master on a semi-regular basis, so don't worry about master (it'll happen for you). it will also get merged into frameworks. cheers ...</pre>
</blockquote>
<p>On November 17th, 2011, 9:35 a.m., <b>Alexey Chernov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, Aaron!
Will push it to KDE/4.7 in the evening.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, please close bug 265657 when you commit.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On November 16th, 2011, 8:55 p.m., Alexey Chernov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Alexey Chernov.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2011, 8:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Several small fixes to allow RenameDialog form and its widgets resize itself according to extra information gathered for source and destination items.
Without these fixes RenameDialog in common case appears as shown on screenshot 1 (without preview for files) and 2 (without preview for files). After the fixes it looks like on screenshot 3 and 4. Screen size is respected correctly, if space doesn't allow, scrollbars appears in scroll areas as before.
What's done:
- private class contains a couple of new members to save some data between methods
- new private slot resizePanels() added to resize information scroll area after metadata for items is fetched
- preview jobs are created not at once but at the moment when metadata is fetched and the width of scroll areas is defined, it allows to render a little bigger preview to fit to size of metadata
And one question: where should I push changes instead of 'master' branch e.g. to have them merged in 4.8? They seem to be rejected for master now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Quite thoroughly tested in case of preview and no preview, all the Qt layout issues are tested and seem to be OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/renamedialog.h <span style="color: grey">(ddd3338ad14911808d728b359e568c1436912096)</span></li>
<li>kio/kio/renamedialog.cpp <span style="color: grey">(b4cb5656d568da93e28bb56df04501600cc2364f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103160/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103160/s/338/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/16/old_rename_dialog_400x100.png" style="border: 1px black solid;" alt="RenameDialog (no file preview) without the patch" /></a>
<a href="http://git.reviewboard.kde.org/r/103160/s/339/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/16/old_rename_dialog_preview_400x100.png" style="border: 1px black solid;" alt="RenameDialog (with file preview) without the patch" /></a>
<a href="http://git.reviewboard.kde.org/r/103160/s/340/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/16/new_rename_dialog_no_preview_400x100.png" style="border: 1px black solid;" alt="RenameDialog (no file preview) with the patch" /></a>
<a href="http://git.reviewboard.kde.org/r/103160/s/341/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/16/new_rename_dialog_400x100.png" style="border: 1px black solid;" alt="RenameDialog (with file preview) with the patch" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>