<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103109/">http://git.reviewboard.kde.org/r/103109/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4acac3ad3fa7c3c212c4f9c123013daef8b07bec by Dawit Alemayehu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 10th, 2011, 10:39 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Andreas Schneider.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2011, 10:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch:
- Implements SlaveBase::copy so that copying to and from the local filesystem is optimized. This makes the common use case of uploading and downloading to and from the local file system much much faster.
- Sends the correct mime-type information when download a file from remote server.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Upload a large file from local file system to sftp server, cancel while still in progress and redo the upload.
- Download a large file from sftp server to file system, cancel while still in progress and redo the download.
- Repeat steps #1 and #2 with a list of files instead of just one large file.
- Repeat the above steps after disabling "Mark partially uploaded files".
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/sftp/kio_sftp.h <span style="color: grey">(c937e2e)</span></li>
<li>kioslave/sftp/kio_sftp.cpp <span style="color: grey">(adc918a)</span></li>
<li>kioslave/sftp/sftp.protocol <span style="color: grey">(696647d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103109/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>