<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102799/">http://git.reviewboard.kde.org/r/102799/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 23rd, 2011, 4:22 p.m., <b>Ralf Jung</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any news? Can I ship this (simplified) version of the original request?</pre>
</blockquote>
<p>On October 23rd, 2011, 10:20 p.m., <b>Oswald Buddenhagen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in qt review terms, you get a +1 from me. this code is pretty much unmaintained, so it's unlikely that you'll get more feedback than that.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am quit new to this reviewing, so far I assumed I should only commit if I get a "Ship it".
Anyway, I will wait some more days for objections, and then commit. Thanks for your feedback!</pre>
<br />
<p>- Ralf</p>
<br />
<p>On October 12th, 2011, 4:55 p.m., Ralf Jung wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Ralf Jung.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2011, 4:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, the "User account & password" KCM refuses to change the user image if KDM is set up not to use user images. That however does not make much sense, all this applet does is writing the image to ~/.face.icon, which the user can do manually anyway. The fact that KDM might or might not actually display this image in the user selection is unrelated, as KDM is not even the only user of this file: Plasma Kickoff displays it, and maybe more apps use it (GDM uses a different file, though)
This patch therefore removes the check for the KDM settings and makes the KCM simply manage the .face.icon file. It does not fall back to the system default if the user image does not exist, as Plasma Kickoff does not do that either. The patch also adds a button in the "Change face" dialogue to remove the user image, to make it possible to go back to the default state again.
After changing the image, the user still has to log off and on again for Plasma to use it - Plasma would have to somehow listen to changes to that file. I don't know if that is desired.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and verified that the KCM now behaves as desired.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=183245">183245</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdepasswd/kcm/main.h <span style="color: grey">(320126f)</span></li>
<li>kdepasswd/kcm/main.cpp <span style="color: grey">(5ce1961)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102799/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>