<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102691/">http://git.reviewboard.kde.org/r/102691/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 248469c79140f13ec8a5f5dbbf29d25f75b209f3 by Dawit Alemayehu to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 25th, 2011, 4:15 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2011, 4:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is the 4th in the serious of patches designed to resolve bugs and missing functionality in KDE's proxy manager. The changes made with this patch are as follows:
* Add code that resolves a request url's hostname before attempting to match
it against the no proxy for list so long as the "ResolveHostNamesBeforeProxyCheck"
option is set.
* Allow "DIRECT" as a special keyword in the list of proxy server addresses
returned in slaveProtocol(const QString& protocol, QStringList& proxy).
* Change KProtocolManager::proxyFor to properly handle the changes in the new
proxy management dialog (KDE 4.8) where the proxy server port, in the
manual proxy configuration mode, will be saved separated from the address with
a white space.
* Move the code that accounts for SOCKS proxy from KProtocolManager::proxyFor
to KProtocolManager::proxyForUrl where it belongs. The current implementation
only works correctly under one circumstance while breaking the previous behavior
of the function.
* Fix KProtocoManager::proxiesForUrl so that it accounts for the proxy
exception list.
* Update API documentation to reflect the changes above.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kprotocolmanager.h <span style="color: grey">(11e43fe)</span></li>
<li>kio/kio/kprotocolmanager.cpp <span style="color: grey">(50ebb6e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102691/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>