<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102729/">http://git.reviewboard.kde.org/r/102729/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, but this is simply wrong. There is a specific reason why passwords are not blindly saved into the wallet before they are validated. The idea of prompting the user for password and actually storing that password need to be two separate actions. So the question is from which application or ioslave are you having this problem ?</pre>
<br />
<p>- Dawit</p>
<br />
<p>On September 29th, 2011, 5:37 a.m., Ben Cooksley wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, Dawit Alemayehu and David Faure.</div>
<div>By Ben Cooksley.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2011, 5:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As of commit 2317acb1da0eefef322d9bac046187fc067cc27b (by adawit) KWallet is never used for password storage by KPasswdServer. It still reads, but never writes. This patch very roughly fixes it to get password saving in KWallet functional again.
There is probably a much nicer way to fix it, but I just wanted it to work again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checking the "Save Password" box when KWallet is enabled leads to the password being saved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpasswdserver/kpasswdserver.cpp <span style="color: grey">(cc8ded2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102729/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>