<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102588/">http://git.reviewboard.kde.org/r/102588/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 13th, 2011, 9:40 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Probably, it will be better if the new label be in red color"
never use hardcoded colours, as that causes problems for accessibility and themability.
in any case, i'd rather see a real fix for this than making the existing dialog more cluttered and filled with technical information. there are a number of ways of addressing this, but the most natural feeling might be to show the user what the active sessions are as soon as they press "reboot" or "shutdown". this should probably be done in the same dialog (to avoid dialogs going away and coming back, which always looks ugly), replacing the UI that was previously there. something, perhaps, like:
"The following sessions are currently active on this computers, preventing an immediate [reboot|shutdown]:
* List
* Of
* Sessions
Would you like to terminate these other sessions and [reboot|shutdown] or only log out of this current session?
( Log out only ) ( [ Reboot | Shutdown ] )"
if we can't make KDM terminate the other sessions until the current session is done, but perhaps also let them know at this point that they will be prompted to terminate these other sessions after logout.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see KApplication::requestShutdown(). kdm may very well make a forced shutdown, but depending on the actual request and the configured policy, it may refuse to perform the action or interactively ask for authorization. doing the authorization already within the session is a major task.</pre>
<br />
<p>- Oswald</p>
<br />
<p>On September 12th, 2011, 4:32 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2011, 4:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not a proper fix for the bug, but helps to know that when you press the shutdown or reboot button it will not be shutting down nor rebooting until you press another button or manually close the other sessions.
Is it possible to add a Warning icon in the button (instead of (*))?
Probably, it will be better if the new label be in red color? Am I right?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The additional message is only shown when there are more than the actual session active.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=183274">183274</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/shutdowndlg.h <span style="color: grey">(e5f0942)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(57d9652)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102588/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>