<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102541/">http://git.reviewboard.kde.org/r/102541/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 6th, 2011, 4:28 p.m., <b>Sebastian Doerner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me. Peter, are you fine with this? The plugin itself will follow next.</pre>
</blockquote>
<p>On September 6th, 2011, 6:58 p.m., <b>Peter Penz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Frank: I'm fine with the interface extensions!
@Vishesh: Thanks for the patch, it looks fine. Please give me a little bit time to get Dolphin 2 into a state where it shows the version plugin states again, I plan to be finished during the next 10 days with this (~ 16. September). I'd like to take the chance when having a KVersionControlPlugin2 interface to also fix some const-errors of the previous interface. But to test this I need first to get back the version control plugins functionality in Dolphin 2 :-)</pre>
</blockquote>
<p>On September 6th, 2011, 8:32 p.m., <b>Vishesh Yadav</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok. So I should put this patch on hold atm, right?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, please. I'll contact you as soon as the patch can be merged.</pre>
<br />
<p>- Peter</p>
<br />
<p>On September 6th, 2011, 3:51 p.m., Vishesh Yadav wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, KDE Base Apps, Peter Penz, and Sebastian Doerner.</div>
<div>By Vishesh Yadav.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2011, 3:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added KVersionControlPlugin2 interface to let version control plugins be able to show context menu anywhere not just in repositories. Will be useful to implement commands like Clone(in Git, Hg) or Checkout(in SVN). Part of GSoC project "Mercurial Plugin for Dolphin" http://goo.gl/6B2ly
Not much changes. Just added one function right now. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. With my Mercurial plugin and modified Dolphin 1.7 source code, whose patch I havent posted as Dolphin 2 is now coming up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/konq/CMakeLists.txt <span style="color: grey">(651beff)</span></li>
<li>lib/konq/kversioncontrolplugin.h <span style="color: grey">(e6cb2b4)</span></li>
<li>lib/konq/kversioncontrolplugin2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/konq/kversioncontrolplugin2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102541/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>