<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102345/">http://git.reviewboard.kde.org/r/102345/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102345/diff/1/?file=32008#file32008line237" style="color: black; font-weight: bold; text-decoration: underline;">kfile/kurlnavigatorbutton.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KUrlNavigatorButton::paintEvent(QPaintEvent* event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">237</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">style</span><span class="o">-></span><span class="n">drawControl</span><span class="p">(</span><span class="n">QStyle</span><span class="o">::</span><span class="n">CE_PushButtonLabel</span><span class="p">,</span> <span class="o">&</span><span class="n">option</span><span class="p">,</span> <span class="o">&</span><span class="n">painter</span><span class="p">,</span> <span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem with using CE_PushButtonLabel is that the text is painted against the background color suited for buttons, i.e. QPalette::Button.
The setPen stuff above the call has been added to make sure the text is visible on the background the navigator uses, which is QPalette::Window.
There are several ways to resolve that:
a. Keep using drawText, and add the correct Qt flag for accelerator drawing
b. Use QStyle::drawItemText
c. Adjust the palette, as is done some lines above (or reuse that palette by code refactoring).
I would use "b" if you ask me. Note that you can remove the setPen stuff if you no longer use drawText.</pre>
</div>
<br />
<p>- Christoph</p>
<br />
<p>On August 16th, 2011, 6:24 p.m., José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2011, 6:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes KUrlNavigator focusable.
Also, QStyle::drawControl is used instead of QPainter::drawText in KUrlNavigatorButton, because accelerators are set in the buttons and drawText did not display them correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kurlnavigator.cpp <span style="color: grey">(e71c979)</span></li>
<li>kfile/kurlnavigatorbutton.cpp <span style="color: grey">(5d38e56)</span></li>
<li>kfile/kurlnavigatorbuttonbase.cpp <span style="color: grey">(45f8eee)</span></li>
<li>kfile/kurlnavigatorbuttonbase_p.h <span style="color: grey">(70aacb3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102345/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>