<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101902/">http://git.reviewboard.kde.org/r/101902/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d0335a61536c3e9b2dfb710cb43689e9452e488c by Kevin Ottens to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 9th, 2011, 3:43 p.m., Kevin Ottens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Kevin Ottens.</div>
<p style="color: grey;"><i>Updated July 9, 2011, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This class is meant to get the D-Bus registration logic out of KApplication, so that it can also be easily provided to QCoreApplication. It also allows to easily provide the KUniqueApplication behavior, which is tested with the accompanying unit test.
Note that it's a somewhat early review request, I'm aware that the APIDOX is missing for instance. It's just that it'll likely be a generally useful class, so I'd like to gather feedback early. In short, just in case you were wondering why it seems unfinished: it is unfinished. :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/CMakeLists.txt <span style="color: grey">(4d96b50)</span></li>
<li>kdecore/kernel/kdbusservice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdecore/kernel/kdbusservice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdecore/tests/CMakeLists.txt <span style="color: grey">(7c3db77)</span></li>
<li>kdecore/tests/kdbusservicetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101902/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>