<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101515/">http://git.reviewboard.kde.org/r/101515/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 316a2e7d9864af1e1576093a1a9c3648a68b9502 by Simon Persson to branch KDE/4.7.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 6th, 2011, 8:46 a.m., Simon Persson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Michael Jansen.</div>
<div>By Simon Persson.</div>
<p style="color: grey;"><i>Updated June 6, 2011, 8:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of two patches to fix a set of bugs for global shortcuts involving shift key. Not sure if this can go in 4.7 because of the freeze? It adds a new function to the API for the sake of a bugfix. Prepared the following commit message:
Export the function isShiftAsModifierAllowed()
This function inside KKeySequnceWidgetPrivate is needed by kglobalaccel,
export here rather than duplicating code and risk falling out of sync.
Also add Qt::Key_Backtab to the list, this is not needed internally
since there is a special case for Alt+Shift+Tab to not be recorded as
Alt+Backtab but other users of this function will need it.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=179504">179504</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=197548">197548</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=215030">215030</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/kkeysequencewidget.h <span style="color: grey">(b9aafdc)</span></li>
<li>kdeui/widgets/kkeysequencewidget.cpp <span style="color: grey">(a35c2b4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101515/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>