<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102231/">http://git.reviewboard.kde.org/r/102231/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the patch is fine, but I need to note two things:
1) I don't really like the addition of a new internalFoo() method in KAboutData. Imho, these should be removed in frameworks 5. But I will accept it as a temporary solution in kdelibs 4
2) DrKonqi also needs a patch to handle that argument... This patch should not be commited before drkonqi has been patched to recognize that argument.</pre>
<br />
<p>- George</p>
<br />
<p>On August 5th, 2011, 11:24 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, kdelibs, George Kiagiadakis, and Darío Andrés Rodríguez.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2011, 11:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some applications, such as muon and Calligra apps, specify a bugzilla product/component via the KAboutData::setProductName() call. This works fine for bug reports via the "Report Bug..." menu, but fails for crashes. These currently go to "kde/general" when the product is not found.
This patch adds a "--productname" parameter to the internal DrKonqi invokation call from the KDE default crash handler, and it is expected that DrKonqi developers decide if they add this feature in DrKonqi. It should handle both pure product names (such as "muon"), as well as product/component combinations (e.g. "muon/installer").</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I forced a crash via Q_ASSERT in a test application, and the "--productname" parameter got added when it was specified via setProductName(). DrKonqi failed to handle it, though, it aborted with "drkonqi: Unknown option 'productname'."</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/kernel/kaboutdata.h <span style="color: grey">(16861f4)</span></li>
<li>kdecore/kernel/kaboutdata.cpp <span style="color: grey">(e49bddb)</span></li>
<li>kdeui/util/kcrash.cpp <span style="color: grey">(b7abece)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102231/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>