<br><br><div class="gmail_quote">On Thu, Aug 4, 2011 at 5:31 AM, Albert Astals Cid <span dir="ltr"><<a href="mailto:tsdgeos@terra.es">tsdgeos@terra.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102179/" target="_blank">http://git.reviewboard.kde.org/r/102179/</a>
</td>
</tr>
</tbody></table>
<br>
</div><div class="im"><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On August 4th, 2011, 3:19 a.m., <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I do not like this patch for the very reason you stated. I do not want the mutex there either because it is rather expensive. As it stands we start a thread for each lookup right now which in of itself is already too expensive for my taste. Hence, I will have to think of some other way to avoid the even worse solution of creating a local even loop.
Having said that, are you using a slow DNS server ? The only way the lookup thread gets terminated is if your nameserver takes longer than 1000 ms per query. That is because the two KUriFilterPlugins that use it set a timeout value of that duration. Otherwise, that code path should not be encountered at all!</pre>
</blockquote>
</blockquote>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">So you do not want a patch that fixes konqueror crashing 75% times i use it in exchange of having a small memory leak once in a blue moon? Awesome.</pre>
</div></div></blockquote><div>Did I say I do not want the patch ?? All I said was need to think of a better way to fix this patch! Clam down.</div></div>