<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101919/">http://git.reviewboard.kde.org/r/101919/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 11th, 2011, 9 p.m., <b>Peter Penz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch, looks good!</pre>
</blockquote>
<p>On July 11th, 2011, 10:24 p.m., <b>Peter Penz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed to 4.7 (is already fixed for Dolphin 2.0 that will get merged to master around beginning of August)</pre>
</blockquote>
<p>On July 20th, 2011, 2:42 p.m., <b>Marcel Partap</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">still nothing pushed to public repo. huh? (:</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pushed to kde-baseapps to KDE/4.7 with commit c4321a1b1dead10be191b23b08f8b53983633b23 on the 12th of July.</pre>
<br />
<p>- Peter</p>
<br />
<p>On July 11th, 2011, 8:45 p.m., Marcel Partap wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, David Faure and Peter Penz.</div>
<div>By Marcel Partap.</div>
<p style="color: grey;"><i>Updated July 11, 2011, 8:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At the point where m_viewModeController->setUrl(url) was invoked in current code, the view does not yet exist because it is only created in applyViewProperties(). Moving the call after view creation is not enough however. The DolphinView's url itself has to be set, that implies setting the url of the VMC. Correcting this makes the showEvent() hack unnecessary.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(48967e6)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(681ce74)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101919/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>