<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101791/">http://git.reviewboard.kde.org/r/101791/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 2094fbbcb8dea70279252979bad982530aab9088 by Luigi Toscano to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 27th, 2011, 11:16 p.m., Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Burkhard Lück, Rex Dieter, and Albert Astals Cid.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated June 27, 2011, 11:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Previously, local.l10n.xml was defined to use a build-time generated file containing the a list of languages for which we provides customizations (see kdoctools/customization/xsl). It seems that this is not the intended way for customization to work; it used to work by accident for docbook-xsl<=1.75 but the new optimaized l10n structure introduced with docbook-xsl>=1.76 broke it (see: http://lists.oasis-open.org/archives/docbook-apps/201009/msg00143.html )
The idea now is to directly load the correct customization file for the required language.
In order to fix the generated documentation, this must be regenerated again using the newly built meinproc.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing performed on Debian testing (kdelibs 4.7, docbook-xslt 1.75/1.76) and Fedora 15 (kdelibs trunk and 4.6.4, docbook-xslt 1.75/1.76, thanks to rdieter).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=271331">271331</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdoctools/CMakeLists.txt <span style="color: grey">(06525c638b1a34903b9ad6f693cbde6f3e18204d)</span></li>
<li>kdoctools/customization/kde-include-common.xsl.cmake <span style="color: grey">(ad35f2000a981798fd4ef63f6719469086db2a13)</span></li>
<li>kdoctools/customization/kde-include-man.xsl.cmake <span style="color: grey">(8727ef26d28f2fcdd7df3005d2c191de83c484b5)</span></li>
<li>kdoctools/customization/xsl/ca.xml <span style="color: grey">(fd7918596c3eaa79d58282699fa4e016263314c9)</span></li>
<li>kdoctools/customization/xsl/de.xml <span style="color: grey">(7a965653a1588145f6175c7ccc9cbd2ed5ca496c)</span></li>
<li>kdoctools/customization/xsl/el.xml <span style="color: grey">(b1aa01f84e36f1d3b7207560e33dfc634fed31cc)</span></li>
<li>kdoctools/customization/xsl/en.xml <span style="color: grey">(0a6f7e6d5dadba9eb0a6b6813716478dbfe47cbc)</span></li>
<li>kdoctools/customization/xsl/es.xml <span style="color: grey">(04663f4e5b9e86b76a404676ed706436f683b76f)</span></li>
<li>kdoctools/customization/xsl/et.xml <span style="color: grey">(d764e42e6ef9a27453f1c13562dd6101b1171b35)</span></li>
<li>kdoctools/customization/xsl/fr.xml <span style="color: grey">(15a642c1e54756cf25477b1be5257e2b1e85946a)</span></li>
<li>kdoctools/customization/xsl/gl.xml <span style="color: grey">(c13a714215bacc31b0c7ea495048b3adf78e1d28)</span></li>
<li>kdoctools/customization/xsl/it.xml <span style="color: grey">(770b459869656b8d4bfc53719c43adcb6f9674df)</span></li>
<li>kdoctools/customization/xsl/lt.xml <span style="color: grey">(5221d96ff9e4ab6035f515e8ec546841b5961991)</span></li>
<li>kdoctools/customization/xsl/nl.xml <span style="color: grey">(f3996ca2829f6973230d26cd2864607e835949c6)</span></li>
<li>kdoctools/customization/xsl/nn.xml <span style="color: grey">(e93a3f9bd7052db5ed4e8b4c8c6d928958870390)</span></li>
<li>kdoctools/customization/xsl/pl.xml <span style="color: grey">(a9c0922c22c625b052db7bbc07337030a62716a6)</span></li>
<li>kdoctools/customization/xsl/pt.xml <span style="color: grey">(e218846e890b1ac41797272a352d614024d6effd)</span></li>
<li>kdoctools/customization/xsl/pt_br.xml <span style="color: grey">(9d6b96231710f28d819a78d4e2b36914e39d328b)</span></li>
<li>kdoctools/customization/xsl/ru.xml <span style="color: grey">(ff8c8424808ab9f88d00691f06ea799b6ebed839)</span></li>
<li>kdoctools/customization/xsl/sl.xml <span style="color: grey">(058e939b983fbe1acef56396d1c1cecd9cbded39)</span></li>
<li>kdoctools/customization/xsl/sr.xml <span style="color: grey">(3572284240d05ba4a46ea08197f059d96652793d)</span></li>
<li>kdoctools/customization/xsl/sv.xml <span style="color: grey">(af3031c7556a58999dc2454446c80ae205702a0b)</span></li>
<li>kdoctools/customization/xsl/tr.xml <span style="color: grey">(7ceae61c3dd556a65c093fd2ef1868c33996b1a3)</span></li>
<li>kdoctools/customization/xsl/uk.xml <span style="color: grey">(60ab441ed2984bda1b0a9f89fc2f7113af68ac8c)</span></li>
<li>kdoctools/docbookl10nhelper.cpp <span style="color: grey">(feab0478e20b1299c1951c20c6f46c25d2b570ef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101791/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>