<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101931/">http://git.reviewboard.kde.org/r/101931/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 12th, 2011, 4:30 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have you run kdialog_unittest?</pre>
</blockquote>
<p>On July 12th, 2011, 7:48 p.m., <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">$ make test
Running tests...
Test project /home/kdedev/svn/build/kdelibs/kdeui/tests
Start 1: kdeui-kactioncollectiontest
1/39 Test #1: kdeui-kactioncollectiontest ........ Passed 0.19 sec
Start 2: kdeui-kactioncategorytest
2/39 Test #2: kdeui-kactioncategorytest .......... Passed 0.15 sec
Start 3: kdeui-kbuttongrouptest
3/39 Test #3: kdeui-kbuttongrouptest ............. Passed 0.49 sec
Start 4: kdeui-kcompletioncoretest
4/39 Test #4: kdeui-kcompletioncoretest .......... Passed 0.04 sec
Start 5: kdeui-kconfigguitest
5/39 Test #5: kdeui-kconfigguitest ............... Passed 0.11 sec
Start 6: kdeui-kconfigskeletontest
6/39 Test #6: kdeui-kconfigskeletontest .......... Passed 0.04 sec
Start 7: kdeui-kdualactiontest
7/39 Test #7: kdeui-kdualactiontest .............. Passed 0.12 sec
Start 8: kdeui-kfadewidgeteffecttest
8/39 Test #8: kdeui-kfadewidgeteffecttest ........ Passed 0.08 sec
Start 9: kdeui-kfindtest
9/39 Test #9: kdeui-kfindtest .................... Passed 0.08 sec
Start 10: kdeui-kglobalsettingstest
10/39 Test #10: kdeui-kglobalsettingstest .......... Passed 0.24 sec
Start 11: kdeui-kglobalshortcuttest
11/39 Test #11: kdeui-kglobalshortcuttest ..........***Failed 3.44 sec
Start 12: kdeui-kmainwindow_unittest
12/39 Test #12: kdeui-kmainwindow_unittest ......... Passed 1.10 sec
Start 13: kdeui-klineedit_unittest
13/39 Test #13: kdeui-klineedit_unittest ........... Passed 0.42 sec
Start 14: kdeui-ktextedit_unittest
14/39 Test #14: kdeui-ktextedit_unittest ........... Passed 0.14 sec
Start 15: kdeui-kcombobox_unittest
15/39 Test #15: kdeui-kcombobox_unittest ........... Passed 0.24 sec
Start 16: kdeui-kdialog_unittest
16/39 Test #16: kdeui-kdialog_unittest ............. Passed 0.69 sec
Start 17: kdeui-kreplacetest
17/39 Test #17: kdeui-kreplacetest ................. Passed 3.70 sec
Start 18: kdeui-kshortcuttest
18/39 Test #18: kdeui-kshortcuttest ................ Passed 0.04 sec
Start 19: kdeui-kstandardactiontest
19/39 Test #19: kdeui-kstandardactiontest .......... Passed 0.16 sec
Start 20: kdeui-kstandardshortcuttest
20/39 Test #20: kdeui-kstandardshortcuttest ........ Passed 0.07 sec
Start 21: kdeui-kuniqueapptest
21/39 Test #21: kdeui-kuniqueapptest ............... Passed 0.89 sec
Start 22: kdeui-kwordwraptest
22/39 Test #22: kdeui-kwordwraptest ................ Passed 0.65 sec
Start 23: kdeui-kapplication_unittest
[snip]</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, i did not mean kdialog_unittest i really meant ./kmessageboxtest (it is a interactive test so you have to check everything looks fine and press buttons to continue)</pre>
<br />
<p>- Albert</p>
<br />
<p>On July 12th, 2011, 4:01 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Darío Andrés Rodríguez.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated July 12, 2011, 4:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Quoting the BR:
"When using KMessageBox::detailedError() it sometimes doesn't resize properly to
show all the text"
See kgpg error dialog without kdelibs patch. The text "your keyringxx" is cut off.
Pressing Details button (kgpg error dialog without kdelibs patch after clicking details)
resizes the dialog properly and all text is visible.
Last screenshot (kgpg error dialog with kdelibs patch) shows the dialog after the start
and before clicking the Deatils button, everything is properly readable.
I commit this review request on behalf of Dario Andres (https://bugs.kde.org/show_bug.cgi?id=193097#c9)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with kgpg error dialog, see third screenshot.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=193097">193097</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kdialog.cpp <span style="color: grey">(32f5df0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101931/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101931/s/200/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/12/kgpg-error-dialog-without-kdelibs-patch_1_400x100.png" style="border: 1px black solid;" alt="kgpg error dialog without kdelibs patch" /></a>
<a href="http://git.reviewboard.kde.org/r/101931/s/201/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/12/kgpg-error-dialog-without-kdelibs-patch-details_400x100.png" style="border: 1px black solid;" alt="kgpg error dialog without kdelibs patch after clicking details" /></a>
<a href="http://git.reviewboard.kde.org/r/101931/s/203/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/12/kgpg-error-dialog-with-kdelibs-patch_400x100.png" style="border: 1px black solid;" alt="kgpg error dialog with kdelibs patch" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>