<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101885/">http://git.reviewboard.kde.org/r/101885/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 11th, 2011, 11:24 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101885/diff/1/?file=26347#file26347line103" style="color: black; font-weight: bold; text-decoration: underline;">kio/kfile/krecentdocument.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KRecentDocument::add(const KUrl& url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">103</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kamd</span><span class="p">.</span><span class="n">call</span><span class="p">(</span><span class="s">"RegisterResourceEvent"</span><span class="p">,</span> <span class="n">desktopEntryName</span><span class="p">,</span> <span class="p">(</span><span class="n">uint</span><span class="p">)</span><span class="mi">0</span><span class="p">,</span> <span class="n">url</span><span class="p">.</span><span class="n">url</span><span class="p">(),</span> <span class="p">(</span><span class="n">uint</span><span class="p">)</span><span class="mi">0</span><span class="p">,</span> <span class="p">(</span><span class="n">uint</span><span class="p">)</span><span class="mi">0</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be an asyncCall?</pre>
</blockquote>
<p>On July 11th, 2011, 11:52 a.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, we don't need a return value or anything
apart from that, can I commit?</pre>
</blockquote>
<p>On July 11th, 2011, 2:51 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">personally, i don't see why libkactivities can not be used here. it literally makes zero sense to have a library in experimental and then not use it because it is experimental. iow, either we get rid of the library and just sprinkle dbus calls and duplicated code everywhere (which would be insane) or we use the library as an internal dependency. how else are we supposed to ensure libkactivities matures? or is the plan to just let it sit there in kdelibs/experimental and never actually be used?
so, no, i'm not personally in favor of seeing this patch go in as-is. i think it should be using libkactivities.</pre>
</blockquote>
<p>On July 11th, 2011, 3:07 p.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The reason is quite simple - kdelibs can not depend on kdelibs/experimental
If you recall, that was one of the stoppers for 4.7 because libplasma depended on experimental libkdeclarative (or whatever the name was) and copying the whole libkactivities in private section (like it was the case for the aforementioned) of kio libraries for one single call to the service is a bit too much.
When libkactivities goes out of experimental, we can change this (although, again, making deps between libs for one extremely simple call is something that can be discussed further)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> The reason is quite simple - kdelibs can not depend on kdelibs/experimental
yes, and that is my point of contention. the reason for kdelibs/experimental is to use the libraries as internal, non-public dependencies to allow them to be tested in real world scenarios before entering 'real world' usage as full fledged members of kdelibs. whoever it was that decided that kdelibs/experimental should be packaged separately and treated as "can't be used as a dependency" made a mistake.
unfortunately i was too busy with other things to notice and correct this mistake in time for 4.7. doesn't mean we have to keep perpetuating it, however.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On July 8th, 2011, 5:28 p.m., Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated July 8, 2011, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KRecentDocument now sends info about opened files to the K Activity Manager Daemon so that it can calculate scores for the opened files.
DBus call is made directly instead of using the libkactivities since the library is still in kdelibs/experimental, and the call is quite simple.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Been testing for a couple of months now</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/krecentdocument.cpp <span style="color: grey">(a7f92839e86775e6a2a88073126f1baf6f213e92)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101885/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>