<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101885/">http://git.reviewboard.kde.org/r/101885/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">aside from the blocking nature of the call which is easily fixable, i'm not in favour of adding specific calls to a specific DBus service that may or may not change implementation at any given point in the future. there's a reason why there is library for this: to hide such things behind a function driven API rather than gluing together DBus calls.
the entire _point_ of having libraries in experimental/ is so that they can be _used_ by code in, e.g., kdelibs or workspace without committing immediately to API stability. if that isn't possible, then we may as well cease kdelibs/experimental/ as it then provides zero benefit.
aside from that, it would make a lot of sense imho to take this opportunity to re-think the mechanism behind KRecentDocument: do we want to continue having a flat file on disk as well as a ranked version of the same data as processed by a desktop events system?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101885/diff/1/?file=26347#file26347line103" style="color: black; font-weight: bold; text-decoration: underline;">kio/kfile/krecentdocument.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KRecentDocument::add(const KUrl& url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">103</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kamd</span><span class="p">.</span><span class="n">call</span><span class="p">(</span><span class="s">"RegisterResourceEvent"</span><span class="p">,</span> <span class="n">desktopEntryName</span><span class="p">,</span> <span class="p">(</span><span class="n">uint</span><span class="p">)</span><span class="mi">0</span><span class="p">,</span> <span class="n">url</span><span class="p">.</span><span class="n">url</span><span class="p">(),</span> <span class="p">(</span><span class="n">uint</span><span class="p">)</span><span class="mi">0</span><span class="p">,</span> <span class="p">(</span><span class="n">uint</span><span class="p">)</span><span class="mi">0</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be an asyncCall?</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On July 8th, 2011, 5:28 p.m., Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated July 8, 2011, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KRecentDocument now sends info about opened files to the K Activity Manager Daemon so that it can calculate scores for the opened files.
DBus call is made directly instead of using the libkactivities since the library is still in kdelibs/experimental, and the call is quite simple.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Been testing for a couple of months now</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/krecentdocument.cpp <span style="color: grey">(a7f92839e86775e6a2a88073126f1baf6f213e92)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101885/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>