<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101923/">http://git.reviewboard.kde.org/r/101923/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch! It looks good, but it only makes sense to push it to the 4.7 branch: For master Dolphin 2.0 will be integrated until beginning of August which has a new view-engine that makes this patch obsolete. If you plan to do further fixes for the icons-, details- or column-view (or related classes) please contact me directly before as most probably the patches are not compatible with the new view-engine.</pre>
<br />
<p>- Peter</p>
<br />
<p>On July 11th, 2011, 9:25 p.m., Marcel Partap wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, David Faure and Peter Penz.</div>
<div>By Marcel Partap.</div>
<p style="color: grey;"><i>Updated July 11, 2011, 9:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The auto-calculated width of columns always is same regardless of custom font style so there was sure something wrong..
=> Setting the font in the viewOptions() actually has no effect on either viewport or view, has to be done via setFont(). So
- adding setFont(m_font) in view init phase
- removing font stuff from viewOptions() and NOOP assignment in slotGlobalSettingsChanged()
- avoiding extra inter-object calls by using m_font directly
Also replaced abusing fontMetrics.height for horizontalGap - by coincidence it was more then needed, but for bigger fonts might be 20px and up while usually only 10px is needed. Pixel-perfect calculation required DEEEEEEP tracing throughout QT style rendering stuff - (PM_FocusFrameHMargin+1)*2 seems to be the way it is calculated, +const 4 which is hard-coded all over the place though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cgdb tracing aaall day long ^^</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphindetailsview.cpp <span style="color: grey">(0ce26df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101923/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>