<br><br><div class="gmail_quote">On Mon, Jul 4, 2011 at 10:02 AM, Dawit A <span dir="ltr"><<a href="mailto:adawit@kde.org">adawit@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
The following files all contain set but unused variables:<br>
<br>
kdelibs/kdecore/io/kar.cpp:109:19: warning: variable ‘uid’ set but not<br>
used [-Wunused-but-set-variable]<br>
kdelibs/kdecore/io/kar.cpp:109:24: warning: variable ‘gid’ set but not<br>
used [-Wunused-but-set-variable]<br>
<br>
kdelibs/kdecore/util/kshareddatacache.cpp:751:14: warning: variable<br>
‘freedPagesRequired’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/kjsembed/kjsembed/qobject_binding.cpp:336:18: warning:<br>
variable ‘propSet’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/kdeui/widgets/ktabwidget.cpp:336:15: warning: variable<br>
‘overlap’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/kded/kbuildsycoca.cpp:478:21: warning: variable<br>
‘servicetypeFactory’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/kded/kbuildsycoca.cpp:479:28: warning: variable<br>
‘mimeTypeFactory’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/experimental/libkdeclarative/bindings/icon.cpp:95:33: warning:<br>
variable ‘setter’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/nepomuk/utils/dynamicresourcefacet.cpp:81:10: warning:<br>
variable ‘selectionChanged’ set but not used<br>
[-Wunused-but-set-variable]<br>
<br>
kdelibs/kio/kio/connection.cpp:169:39: warning: variable ‘type’ set<br>
but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/kio/bookmarks/kbookmarkimporter_opera.cc:51:20: warning:<br>
variable ‘version’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/kio/kssl/ksslkeygen.cpp:163:6: warning: variable ‘rc’ set but<br>
not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/knewstuff/knewstuff3/staticxml/staticxmlprovider.cpp:199:14:<br>
warning: variable ‘mode’ set but not used [-Wunused-but-set-variable]<br></blockquote><div><br>Thanks for checking this, that's embarassing, a whole for loop to get a value we don't even use anymore.  I just fixed it on the master branch of kdelibs.<br>
<br>Jeremy<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
kdelibs/interfaces/kimproxy/library/kimproxy.cpp:285:8: warning:<br>
variable ‘newApp’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/kde3support/kdeui/k3dockwidget.cpp:3108:10: warning: variable<br>
‘isOverMainWdg’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/plasma/framesvg.cpp:686:16: warning: variable ‘pos’ set but<br>
not used [-Wunused-but-set-variable]<br>
kdelibs/plasma/private/applethandle.cpp:316:13: warning: variable<br>
‘separator’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/plasma/private/applethandle.cpp:403:13: warning: variable<br>
‘separator’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/plasma/widgets/iconwidget.cpp:1193:15: warning: variable<br>
‘labelRect’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/plasma/widgets/scrollwidget.cpp:673:14: warning: variable<br>
‘moved’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/experimental/libkdeclarative/bindings/icon.cpp:95:33: warning:<br>
variable ‘setter’ set but not used [-Wunused-but-set-variable]<br>
<br>
kdelibs/khtml/html/htmltokenizer.cpp:1724:18: warning: variable<br>
‘endTag’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/rendering/bidi.cpp:1735:16: warning: parameter<br>
‘cleanLineBidiContext’ set but not used [-Wunused-but-set-parameter]<br>
kdelibs/khtml/rendering/render_image.cpp:366:9: warning: variable<br>
‘m_height’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/rendering/table_layout.cpp:393:23: warning: variable<br>
‘last’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/rendering/table_layout.cpp:917:10: warning: variable<br>
‘haveRelative’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/rendering/render_canvasimage.cpp:77:10: warning:<br>
variable ‘drawSelectionTint’ set but not used<br>
[-Wunused-but-set-variable]<br>
kdelibs/khtml/css/css_webfont.cpp:498:10: warning: variable<br>
‘foundLocal’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/editing/jsediting.cpp:616:33: warning: variable ‘it’ set<br>
but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/svg/graphics/qt/SVGResourceClipperQt.cpp:49:10: warning:<br>
variable ‘heterogenousClipRules’ set but not used<br>
[-Wunused-but-set-variable]<br>
kdelibs/khtml/rendering/RenderSVGRoot.cpp:94:13: warning: variable<br>
‘oldBounds’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/rendering/SVGRootInlineBox.cpp:506:13: warning: variable<br>
‘textWidth’ set but not used [-Wunused-but-set-variable]<br>
kdelibs/khtml/rendering/SVGRootInlineBox.cpp:1223:22: warning:<br>
variable ‘lastCharacter’ set but not used [-Wunused-but-set-variable]<br>
<br>
Unlike the -Wunused-parameter fixing this warning messages requires<br>
context because the variable may be set and unused due to a mistake<br>
that can potentially be causing a bug. As such can kdelibs cmake file<br>
be changed to error out, -Werror=unused-but-set-variable, for such<br>
warnings ?<br>
</blockquote></div><br>