<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101800/">http://git.reviewboard.kde.org/r/101800/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 29th, 2011, 1:21 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is definitely an improvement for discoverability. i'm not sure about the exact text (which was not your fault :), see inline comment for that. also, i do think with this change to improve the layout and avoid overly wide dialogs that the button maybe should be moved beneath the file type itself, e.g.:
Type: <mimetype>
[ File Type Options ]
Location: <location></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok I will look into moving the button below the label :)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 29th, 2011, 1:21 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101800/diff/1/?file=25704#file25704line963" style="color: black; font-weight: bold; text-decoration: underline;">kio/kfile/kpropertiesdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KFilePropsPlugin::KFilePropsPlugin( KPropertiesDialog *_props )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">963</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">button</span><span class="o">-></span><span class="n">setT<span class="hl">oolTip</span></span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Edit <span class="hl">f</span>ile <span class="hl">t</span>ype"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">961</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">button</span><span class="o">-></span><span class="n">setT<span class="hl">ext</span></span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Edit <span class="hl">F</span>ile <span class="hl">T</span>ype"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the text (which was already there, yes) is a bit misleading imho. it isn't editing the file type of the file itself, but rather changing the options associated with the file type. so perhaps "File Type Options" would be better?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just copied the tool tip text and capitalized it ;) I will change that</pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On June 29th, 2011, 9:39 a.m., Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated June 29, 2011, 9:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On IRC this evening somebody found it hard to find the options to edit a specific file type. The KCM is a mess unfortunately but I told him that you could edit specific file types directly from the properties dialog.
That button is hard to spot, though, which I also often found annoying. It is neither labled nor does it stand out as “button”.
This patch solves that issue.
It is in need of discussion whether the label itself should stay but the button definitly has to look like a clickable target.
Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screenshot is from the initial attempt where i forgot the capitalization :P)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(3382daa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101800/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>