<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101523/">http://git.reviewboard.kde.org/r/101523/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6026c3a32056bdbae6964e25abf712870edf5aac by Simon Persson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 6th, 2011, 11:24 a.m., Simon Persson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Michael Jansen.</div>
<div>By Simon Persson.</div>
<p style="color: grey;"><i>Updated June 6, 2011, 11:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When entering (ctrl,alt,meta+) shift+tab as a new shortcut KKeySequenceWidget gets "backtab" as the key pressed but records "tab", because it looks/sounds better I guess... When either of backtab or tab is used with shift as a shortcut in an application Qt triggers the shortcut. kglobalaccel gets the keypress event as "backtab" which is correct but only triggers shortcuts with "backtab" in them and such shortcuts are not possible for the user to enter using kshortcutseditor.
This patch makes kglobalaccel look for both tab and backtab when triggered, same as Qt does.
KWin should possibly be patched to have alt+shift+tab as its default shortcut, currently it has alt+shift+backtab (which is why it works even without this patch...). That would solve the issue that currently a user can enter alt+shift+tab as shortcut for something else and the conflict is not detected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using master branch, running in a Xephyr session. Switching between plasma activities with meta+shift+tab now works.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=174142">174142</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=258467">258467</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=261296">261296</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=274006">274006</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kglobalaccel/globalshortcutcontext.cpp <span style="color: grey">(fc2e6a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101523/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>