<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101586/">http://git.reviewboard.kde.org/r/101586/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 19th, 2011, 11:15 p.m., <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, but can you also add Q_ASSERT(m_currentView) before the if (!m_currentView) checks so that in debug mode this will assert. The view should not be null and if it is someone needs to figure out why that is the case.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as per our mail conversation:
"Well if m_currentView can be NULL, then
there is definitely no need to add a Q_ASSERT right ? I was not aware
that it could be until you forwarded what David said ; so forget about
my comment and handle it as David suggested."
I found also now a way to actually make the current view disappear:
start konqueror (in my case starts with empty page), select "Settings -> load view profile -> midnight commander"
This closes the current view in konqi and opens a new window.
Closing active view (Ctrl+Shift+W) crashes konqueror without this patch.
I've committed/pushed it now</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 11th, 2011, 6:56 p.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated June 11, 2011, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add some "currentView" 0-pointer checks in konqueror/src/konqmainwindow.cpp to avoid crashes like #272557</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=272557">272557</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqmainwindow.cpp <span style="color: grey">(a309f48)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101586/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>