<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101498/">http://git.reviewboard.kde.org/r/101498/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 26c378fe5cf0da01b64177470ddddd0eb51add12 by Dawit Alemayehu.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 3rd, 2011, 5:46 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated June 3, 2011, 5:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently it is impossible to scroll through the popup completion items in Konqueror's searchbar plugin. The problem stems from the fact that whenever a user scrolls through the popup completion list, not only does KLineEdit update its text, and as a result emit the textChanged signal, but it also emits the textEdited signal. This causes the searchbar plugin which relies on the textEdited signal to update the matching items from the search engine, to continually retrieve new matches everytime the user presses the arrow keys to scroll through the completion items in the popup completion box. This results in unpredictable behavior since the list is updated while the user is pressing the scrolling keys.
The attached patch stops KLineEdit from emitting textEdited during scrolling through the list of completion items.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=256954">256954</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/klineedit.cpp <span style="color: grey">(0dd3690)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101498/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>