<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101487/">http://git.reviewboard.kde.org/r/101487/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 1st, 2011, 10:48 p.m., <b>Peter Penz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch. I just had a look and if I don't miss anything it should
be sufficient to just add the line:
m_selectedItems = selectedItems();
to DolphinView::setShowHiddenFiles().
I'm not really happy with how the selections are remembered in DolphinView in
general: We have m_selectedItems to remember the selection when e.g. changing
views and there is m_newFileNames for the usecase where the KFileItems are not
available yet and only the new names are known.
I'm currently working on a (let's say) "new view-engine" in Dolphin for 4.8
that should allow us to get rid of at least m_selectedItems but for 4.7 it
would be great if we could get in this fix.
Would it be possible that you check whether 'm_selectedItems =
selectedItems();' is sufficient? I'm quite sure this should work but probably
I'm missing something... Thanks :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed that works too and is a lot (!) nicer. :)
Yeah the m_newFileNames is not really nice and can't handle multiple corner cases like kio operations that were paused in between e.g. because of existing files etc.</pre>
<br />
<p>- Matthias</p>
<br />
<p>On June 1st, 2011, 9:58 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, Peter Penz and Frank Reininghaus.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated June 1, 2011, 9:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still only files that are shown will be selected, thus selecting hidden files and then hiding hidden files will deselect those.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=177215">177215</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(4bc901b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101487/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>