<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101456/">http://git.reviewboard.kde.org/r/101456/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 28th, 2011, 9:29 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The handling of '/' could use KIO::encodeFileName instead, for consistency. I agree about "." and ".." though ;)</pre>
</blockquote>
<p>On May 28th, 2011, 7:16 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder.. don't we need a "isFilename" function that checks if a filename meets all the characters that are allowed in a filename thus returning false when it starts with a / or for example contains a *? or being equal to . or .. ? That would make the use more "portable" since i can imagine other apps benefiting from that (any app that needs to create a file or folder from user input)</pre>
</blockquote>
<p>On May 29th, 2011, 8:32 p.m., <b>Richard J. Moore</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Filenames containing * and ? are perfectly legal. The only truly illegal characters in a unix filename are / and \0. To be portable, you need to consider the underlying filesystem in which a file is being created since this sets the rules, for example FAT has a bunch of characters that can't be used (eg. consider how a filename starting with ? would interact with its file deletion handling). Short version, I don't see how the function you propose could be implemented.
</pre>
</blockquote>
<p>On May 29th, 2011, 11:13 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are completely right. I didn't think about the differences per filesystem.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well if a function like that was to be done it would need at least two parameters.
1. tried file name
2. (target)location of the file
Then you could easily find the mount point and the file system via:
KMountPoint::Ptr mountPoint = KMountPoint::currentMountPoints().findByPath(fileUrl.directory());
const QString mountType = mountPoint->mountType();
Now what I fear is that this could be a costly operation to do that for many files, e.g. when you do a copy operation.
And the result could only be cached for the same directory, yet not for similar ones as you could mount a different file system in a sub directory.</pre>
<br />
<p>- Matthias</p>
<br />
<p>On May 28th, 2011, 6:26 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated May 28, 2011, 6:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nt</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=211751">211751</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kdirmodel.cpp <span style="color: grey">(6bf57be)</span></li>
<li>kio/kio/kfileitemdelegate.cpp <span style="color: grey">(cb3939d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101456/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>