<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101360/">http://git.reviewboard.kde.org/r/101360/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 14th, 2011, 4:01 a.m., <b>Shaun Reich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you sure the behaviour for the Qt method 100% equivalent to the current? I ask this because now that the deprecated method forwards to it, naturally it's quite important to make sure nothing gets fscked up.</pre>
</blockquote>
<p>On May 14th, 2011, 4:10 a.m., <b>Nicolas Alvarez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Someone in #kde-devel tried it a little ago. Apparently one of them renders the placeholder text in italics and the other doesn't (don't remember which).
(Also, using *both* causes both to draw, one unreadably over the other)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the KDE one does it in italics. and this really should be rendered by the style as it is platform dependent: iirc Mac and KDE does it italics, Windows doesn't.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On May 14th, 2011, 12:59 a.m., Davide Bettio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Davide Bettio.</div>
<p style="color: grey;"><i>Updated May 14, 2011, 12:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since Qt 4.7 QLineEdit::setPlaceholderText is available so KLineEdit::clickMessage should be deprecated.
I kept clickMessage as not deprecated in plasma/widgets/lineedit but now is using placeholderText.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/klineedit.h <span style="color: grey">(909d1f7)</span></li>
<li>kdeui/widgets/klineedit.cpp <span style="color: grey">(0dd3690)</span></li>
<li>plasma/widgets/lineedit.cpp <span style="color: grey">(09c0c66)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101360/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>