<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101337/">http://git.reviewboard.kde.org/r/101337/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't know much about the code, just noticed a couple of things in the patch. Being more consistent with other browsers seems like a good thing, though, as long as we don't break existing sites in the process. I doubt many sites code for KIO's UA string, though.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101337/diff/1/?file=16340#file16340line350" style="color: black; font-weight: bold; text-decoration: underline;">kio/kio/kprotocolmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QStringList KProtocolManager::proxiesForUrl( const KUrl &url )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">350</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">.</span><span class="n">call</span><span class="p">(</span><span class="n">QL1S</span><span class="p">(</span><span class="s">"blackListProxy"</span><span class="p">),</span> <span class="n">proxy</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">339</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="n"><span class="hl">dbusIface</span></span><span class="p">.</span><span class="n">call</span><span class="p">(</span><span class="n">QL1S</span><span class="p">(</span><span class="s">"blackListProxy"</span><span class="p">),</span> <span class="n">proxy</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't asyncCall be better, since we don't care about the reply? Or just pass QDBus::NoBlock to call().</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101337/diff/1/?file=16340#file16340line628" style="color: black; font-weight: bold; text-decoration: underline;">kio/kio/kprotocolmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString KProtocolManager::defaultUserAgent( const QString &_modifiers )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">613</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">supp</span> <span class="o">+=</span> <span class="n">QL1<span class="hl">C</span></span><span class="p"><span class="hl">(</span></span><span class="sc"><span class="hl">' '</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">617</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">supp</span> <span class="o">+=</span> <span class="n">QL1<span class="hl">S</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">" "</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why the change?</pre>
</div>
<br />
<p>- Alex</p>
<br />
<p>On May 11th, 2011, 4 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated May 11, 2011, 4 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes the default user-agent string so that it is more aligned with other browsers by
- Dropping 'comptiable' and 'U' from the string.
- Making the platform string, e.g X11, mandatory part of the string.
- Sending the OS name and machine type (i686,x86-64) by default (configurable).
Additionally the patch for kprotocolmanager.cpp also removes the manual use of '%' to append text since kdelibs is now compilable with the QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS flags.
Besides being good for privacy due to less differentiation, this change should make it less likely that a different page will be sent sheerly based on user-agent sniffing. See the attached screen shot for what the full, default, and minimal default user-agent will look like now.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=271720">271720</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/http_slave_defaults.h <span style="color: grey">(af97cfa)</span></li>
<li>kio/kio/kprotocolmanager.cpp <span style="color: grey">(57ec696)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101337/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101337/s/163/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/11/useragent-full_1_400x100.png" style="border: 1px black solid;" alt="UserAgent [FULL]" /></a>
<a href="http://git.reviewboard.kde.org/r/101337/s/164/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/11/useragent-default_1_400x100.png" style="border: 1px black solid;" alt="UserAgent [Default]" /></a>
<a href="http://git.reviewboard.kde.org/r/101337/s/165/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/11/useragent-minimal_400x100.png" style="border: 1px black solid;" alt="UserAgent [Minimal]" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>