<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101333/">http://git.reviewboard.kde.org/r/101333/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c6ae48ccb5e809057a2d83888ad9181b2e5bc0ce by Dawit Alemayehu.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 11th, 2011, 3:58 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated May 11, 2011, 3:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As the summary state, this patch adds a new dbus interface to klaucher, checkForHeldSlave, that can be used to check whether or not there is an io slave being held for a given url. This fixes the last known issue with KIO's put-on-hold feature not working properly. With this patch when a user clicks on a PDF link that points to an ftp server, KIO will no longer require multiple connections to service that single request.
Please note that this fix is not specific to the ftp ioslave. Any ioslave that optimizes its copy operation, i.e. supports the canCopyFromFile/canCopyToFile properties, benefits from this fix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clicking on the example links below should only result in one single connection to the server:
ftp://ftp.kde.org/pub/kde/README_UPLOAD
ftp://ftp.kde.org/pub/kde/printing/kdeprint-handbook.pdf
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/util/klauncher_iface.h <span style="color: grey">(02c6c9b)</span></li>
<li>kinit/klauncher.h <span style="color: grey">(3fbf2d7)</span></li>
<li>kinit/klauncher.cpp <span style="color: grey">(dd45dfe)</span></li>
<li>kinit/klauncher_adaptor.h <span style="color: grey">(0b045c8)</span></li>
<li>kinit/klauncher_adaptor.cpp <span style="color: grey">(c7cf086)</span></li>
<li>kio/kio/scheduler.cpp <span style="color: grey">(34f437e)</span></li>
<li>kio/kio/slave.h <span style="color: grey">(780f3c4)</span></li>
<li>kio/kio/slave.cpp <span style="color: grey">(3679ea9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101333/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>