<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101082/">http://git.reviewboard.kde.org/r/101082/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1855d5963c4fdbc96456dc7ce661b5bccc795472 by Alex Fiestas.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 11th, 2011, 12:22 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated April 11, 2011, 12:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I found 2 places where KAuthorize should be added:
KFileItemActions::addOpenWithActionsTo(QMenu* topMenu, const QString& traderConstraint)
In this method as you can see, the first option is a QMenu pointer where the new "open with" actions will be added. If we don't check in this function if "openwith" is allowed we will end up having "Open with" action (or having to patch all apps :p)
The second place is:
KFileItemActionsPrivate::slotExecuteService(QAction* act)
This is where the actual action is executed, just for """""security""""" and robustness we should check here too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kfileitemactions.cpp <span style="color: grey">(7f7d5c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101082/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>