<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101037/">http://git.reviewboard.kde.org/r/101037/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for working on this, iirc this is needed by many users.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101037/diff/1/?file=13845#file13845line249" style="color: black; font-weight: bold; text-decoration: underline;">kio/kio/kprotocolmanager.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">249</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Returns the <span class="hl">P</span>roxy server address for <span class="hl">a given URL</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">249</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Returns <span class="hl">all </span>the <span class="hl">possible p</span>roxy server address<span class="hl">es</span> for <span class="hl">@p url.</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this return only one proxy server address, as it did before? Otherwise existing code could get broken by this change, I fear.
You added a separate method for getting a stringlist anyway.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101037/diff/1/?file=13846#file13846line299" style="color: black; font-weight: bold; text-decoration: underline;">kio/kio/kprotocolmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static QStringList getSystemProxyFor( const KUrl& url )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">298</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// On Unix/Linux use system environment variables any are set.</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">s/any/if any/</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On April 6th, 2011, 4:31 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 6, 2011, 4:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This the second part of a series of patches designed to improve and bring KIO's proxy support to the levels of KDE 3.5 and beyond. Unlike the first series, https://git.reviewboard.kde.org/r/100971/, these set of patches are focused on the two classes in KIO that are responsible for providing proxy information to all ioslaves, KProtocolManager and KIO::Scheduler. Here are a list of the changes contained within:
KProtocolManager:
------------------
* Add socks proxy support to KProtocolManager.
* Add functions for obtaining multiple proxy URL addresses when configured through PAC scripts.
* Add support for obtaining system proxy information on Windows and Mac platforms. [1]
KIO::Scheduler:
---------------
* Set a new meta-data, "ProxyUrls" with a list of comma separated proxy urls.[2]
[1] Please note that on Linux/Unix platforms system proxy configuration is assumed to be set through enivronment variables and has been supported since the days of KDE 2.0.
[2] The existing meta-data "UseProxy" will still be set with the first url from the list.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/scheduler.cpp <span style="color: grey">(d657bf6)</span></li>
<li>kio/DESIGN.metadata <span style="color: grey">(f5dfcd1)</span></li>
<li>kio/kio/job_p.h <span style="color: grey">(620e487)</span></li>
<li>kio/kio/kprotocolmanager.h <span style="color: grey">(814e2f2)</span></li>
<li>kio/kio/kprotocolmanager.cpp <span style="color: grey">(56e1942)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101037/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>