<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100971/">http://git.reviewboard.kde.org/r/100971/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This the first part of a series of patches designed to improve and bring KIO's proxy support to the levels of KDE 3.5 and beyond. As such this original patch attempts to fix KIO's Proxy Auto Configuration (PAC) detection code so that it works for as many people as possible out of the box. Here is the changelog from local commit:
Features:
- Switched the PAC file parser from KJS to QtScript.
- Implemented the Microsoft IPv6 PAC extensions.
- Implemented support for returning SOCKS proxy information (only SOCKS5).
- Added a new dbus call, proxiesForUrl, that returns all the proxy addresses
for a given url.
- Added a new kpactest file to test the new MS IPv6 extension functions.
Fixes:
- Fixed the DateRange function by adding back two missing months in the static
months array.
- Fixed the DNS related functions by fixing how the lookup works through
the following modification to the KIO DNS caching code:
* Added a function, lookupCachedHostInfoFor, for quering the KIO cache for
information without causing a DNS query.
* Added a function, cacheLookup, for inserting a DNS lookup result into
the KIO cache.
- Fixed myIpAddress by using QNetworkInterface, though this fix is still far
from ideal since it grabs the first suitable interface on multi-homed systems.
Known Issues:
- According to one MS documentation the IPv6 extensions were meant to be accessiable from FindProxyForURLEx function only. Not sure if that is how things are
in partcise, but this impementation does not have such restriction.
Please note that https://git.reviewboard.kde.org/r/100964/ should actually be part of this patch set as well. However, that patch is a fix to a separate piece of helper program that can be backported to the 4.6 branch ; so it was split out into a separate patch.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made sure the unit tests in both kpactest.pac and kpactest2.pac pass as documented in those files.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/hostinfo.cpp <span style="color: grey">(be59358)</span></li>
<li>kio/kio/hostinfo_p.h <span style="color: grey">(d416e65)</span></li>
<li>kio/misc/kpac/CMakeLists.txt <span style="color: grey">(3550c77)</span></li>
<li>kio/misc/kpac/kpactest.pac <span style="color: grey">(fe98c10)</span></li>
<li>kio/misc/kpac/kpactest2.pac <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/misc/kpac/proxyscout.h <span style="color: grey">(ebac780)</span></li>
<li>kio/misc/kpac/proxyscout.cpp <span style="color: grey">(6c42337)</span></li>
<li>kio/misc/kpac/script.h <span style="color: grey">(c802e04)</span></li>
<li>kio/misc/kpac/script.cpp <span style="color: grey">(89ceb82)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100971/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>