<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/579/">http://svn.reviewboard.kde.org/r/579/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the current state of this review? Should it be discarded?</pre>
<br />
<p>- Alex</p>
<br />
<p>On April 18th, 2009, 2:34 a.m., Mathieu Seigneurin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Mathieu Seigneurin.</div>
<p style="color: grey;"><i>Updated April 18, 2009, 2:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,
Right now on kde-4.2.2 a dummy application that uses plain KSystemTrayIcon has
the following behavior:
- app show on current desktop, not obscured
- click on taskbar entry => minimize to taskbar
- click on system tray => minimize to tray
- app on current desktop, obscured
- click on taskbar entry => raise, focus
- click on system tray => raise, focus
- app hidden in systray, not showing or minimized anywhere
- click on systray => show, raise, focus on current desktop
- app shown on other desktop, minimized:
- click on taskbar entry => move user to app's desktop
- click on systray => move user to app's desktop
All this is fine and consistent
But:
- app shown on other desktop, NOT minimized:
- click on taskbar entry => move to app's desktop, un-minimize raise focus
- click on systray => hide app in systray
This last behavior is a bit surprising and is the only inconsistency I can find
between taskbar and systray handling (appart from the very first point which is
obviously what is expected).
Additionaly, there is a bug in the systray handling with regards to windows
showing on all desktops. If that setting is changed between hide/restores from
tray, the cached d->onAllDesktops can be stale. This patch should fix that too.
Thanks for reading!
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think I tested all the combinations of minimize/hide/restore/desktop dance,
but some might well have slipped by...</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=74938">74938</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=188866">188866</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/util/ksystemtrayicon.cpp <span style="color: grey">(955625)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/579/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>